content/browser/streams/stream.cc - Issue 625993002: Split up streams logic to prepare for PlzNavigate RDH changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/streams/stream.cc

Issue 625993002: Split up streams logic to prepare for PlzNavigate RDH changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove TestStreamHandle in favor of just making an empty one. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/loader/stream_writer.cc ('K') | « content/browser/streams/stream.h ('k') | content/browser/streams/stream_handle_impl.h » ('j') | content/browser/streams/stream_handle_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/streams/stream.cc

diff --git a/content/browser/streams/stream.cc b/content/browser/streams/stream.cc

index d10770c42d2d6f5b0dd6498e420eaa04807cbeec..966313cc45d2ef58c8c5b01f3881b952698a3f35 100644

--- a/content/browser/streams/stream.cc

+++ b/content/browser/streams/stream.cc

@@ -160,15 +160,9 @@ Stream::StreamState Stream::ReadRawData(net::IOBuffer* buf,

return STREAM_HAS_DATA;

}

-scoped_ptr<StreamHandle> Stream::CreateHandle(

- const GURL& original_url,

- const std::string& mime_type,

- scoped_refptr<net::HttpResponseHeaders> response_headers) {

+scoped_ptr<StreamHandle> Stream::CreateHandle() {

CHECK(!stream_handle_);

- stream_handle_ = new StreamHandleImpl(weak_ptr_factory_.GetWeakPtr(),

- original_url,

- mime_type,

- response_headers);

+ stream_handle_ = new StreamHandleImpl(weak_ptr_factory_.GetWeakPtr());

return scoped_ptr<StreamHandle>(stream_handle_).Pass();

}