content/browser/frame_host/render_frame_host_impl.h - Issue 622793002: Group the different permission related methods in the content api.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « chrome/browser/notifications/desktop_notification_service.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 0dd9bffbdcaf380120c07101dd57a81eab745ff0..d78a0fe3a5f06d81b602df914e6d321be21a0fbe 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -22,7 +22,6 @@

#include "content/public/browser/render_frame_host.h"

#include "content/public/common/javascript_message_type.h"

#include "net/http/http_response_headers.h"

-#include "third_party/WebKit/public/platform/WebNotificationPermission.h"

#include "third_party/WebKit/public/web/WebTextDirection.h"

#include "ui/accessibility/ax_node_data.h"

#include "ui/base/page_transition_types.h"

@@ -448,7 +447,7 @@ class CONTENT_EXPORT RenderFrameHostImpl

bool CanCommitURL(const GURL& url);

void PlatformNotificationPermissionRequestDone(

- int request_id, blink::WebNotificationPermission permission);

+ int request_id, bool granted);

Bernhard Bauer 2014/10/20 14:57:24 Does this fit on one line? If not, at least put th

Miguel Garcia 2014/10/21 17:17:12 Done.

// Update the the singleton FrameAccessibility instance with a map

// from accessibility node id to the frame routing id of a cross-process