Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: content/browser/media/midi_dispatcher_host.cc

Issue 622793002: Group the different permission related methods in the content api. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/media/midi_dispatcher_host.h" 5 #include "content/browser/media/midi_dispatcher_host.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "content/browser/child_process_security_policy_impl.h" 8 #include "content/browser/child_process_security_policy_impl.h"
9 #include "content/browser/frame_host/render_frame_host_impl.h" 9 #include "content/browser/frame_host/render_frame_host_impl.h"
10 #include "content/common/media/midi_messages.h" 10 #include "content/common/media/midi_messages.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 int bridge_id, 71 int bridge_id,
72 const GURL& origin, 72 const GURL& origin,
73 bool user_gesture) { 73 bool user_gesture) {
74 int render_process_id = render_frame_host->GetProcess()->GetID(); 74 int render_process_id = render_frame_host->GetProcess()->GetID();
75 int render_frame_id = render_frame_host->GetRoutingID(); 75 int render_frame_id = render_frame_host->GetRoutingID();
76 76
77 PendingPermission pending_permission( 77 PendingPermission pending_permission(
78 render_process_id, render_frame_id, bridge_id); 78 render_process_id, render_frame_id, bridge_id);
79 pending_permissions_.push_back(pending_permission); 79 pending_permissions_.push_back(pending_permission);
80 80
81 GetContentClient()->browser()->RequestMidiSysExPermission( 81 GetContentClient()->browser()->RequestPermission(
82 content::PERMISSION_MIDI_SYSEX,
82 web_contents(), 83 web_contents(),
83 bridge_id, 84 bridge_id,
84 origin, 85 origin,
85 user_gesture, 86 user_gesture,
86 base::Bind(&MidiDispatcherHost::WasSysExPermissionGranted, 87 base::Bind(&MidiDispatcherHost::WasSysExPermissionGranted,
87 weak_factory_.GetWeakPtr(), 88 weak_factory_.GetWeakPtr(),
88 render_process_id, render_frame_id, bridge_id), 89 render_process_id, render_frame_id, bridge_id));
89 &pending_permissions_.back().cancel);
90 } 90 }
91 91
92 void MidiDispatcherHost::CancelPermissionRequestsForFrame( 92 void MidiDispatcherHost::CancelPermissionRequestsForFrame(
93 RenderFrameHost* render_frame_host) { 93 RenderFrameHost* render_frame_host) {
94 int render_process_id = render_frame_host->GetProcess()->GetID(); 94 int render_process_id = render_frame_host->GetProcess()->GetID();
95 int render_frame_id = render_frame_host->GetRoutingID(); 95 int render_frame_id = render_frame_host->GetRoutingID();
96 96
97 for (size_t i = 0; i < pending_permissions_.size(); ++i) { 97 for (size_t i = 0; i < pending_permissions_.size(); ++i) {
98 if (pending_permissions_[i].render_process_id == render_process_id && 98 if (pending_permissions_[i].render_process_id == render_process_id &&
99 pending_permissions_[i].render_frame_id == render_frame_id) { 99 pending_permissions_[i].render_frame_id == render_frame_id) {
100 if (!pending_permissions_[i].cancel.is_null()) 100 GetContentClient()->browser()->CancelPermissionRequest(
101 pending_permissions_[i].cancel.Run(); 101 content::PERMISSION_MIDI_SYSEX,
jam 2014/10/20 20:13:57 nit: here and above, and elsewhere, no "content::"
Miguel Garcia 2014/10/21 17:17:12 Done.
102 web_contents(), pending_permissions_[i].bridge_id,
103 render_frame_host->GetLastCommittedURL());
104
102 pending_permissions_.erase(pending_permissions_.begin() + i); 105 pending_permissions_.erase(pending_permissions_.begin() + i);
103 return; 106 return;
104 } 107 }
105 } 108 }
106 } 109 }
107 110
108 void MidiDispatcherHost::WasSysExPermissionGranted(int render_process_id, 111 void MidiDispatcherHost::WasSysExPermissionGranted(int render_process_id,
109 int render_frame_id, 112 int render_frame_id,
110 int bridge_id, 113 int bridge_id,
111 bool is_allowed) { 114 bool is_allowed) {
(...skipping 13 matching lines...) Expand all
125 GrantSendMidiSysExMessage(render_process_id); 128 GrantSendMidiSysExMessage(render_process_id);
126 } 129 }
127 130
128 pending_permissions_.erase(pending_permissions_.begin() + i); 131 pending_permissions_.erase(pending_permissions_.begin() + i);
129 return; 132 return;
130 } 133 }
131 } 134 }
132 } 135 }
133 136
134 } // namespace content 137 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698