Add a resource throttle for sub frame unless scheme of uri is acceptable

chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 67 matching lines @@
 #endif
 
 #if defined(USE_SYSTEM_PROTOBUF)
 #include <google/protobuf/repeated_field.h>
 #else
 #include "third_party/protobuf/src/google/protobuf/repeated_field.h"
 #endif
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/android/intercept_download_resource_throttle.h"
+#include "chrome/browser/android/url_utilities.h"
 #include "chrome/browser/ui/android/infobars/auto_login_prompter.h"
 #include "components/navigation_interception/intercept_navigation_delegate.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/login/signin/merge_session_throttle.h"
 // TODO(oshima): Enable this for other platforms.
 #include "chrome/browser/renderer_host/offline_resource_throttle.h"
 #endif
 
@@ skipping 218 matching lines @@
       request->SetPriority(net::IDLE);
     }
   }
 
   ProfileIOData* io_data = ProfileIOData::FromResourceContext(
       resource_context);
 
 #if defined(OS_ANDROID)
   // TODO(davidben): This is insufficient to integrate with prerender properly.
   // https://crbug.com/370595
-  if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME && !is_prerendering) {
+  if (!is_prerendering && (resource_type == content::RESOURCE_TYPE_MAIN_FRAME ||
+                           (resource_type == content::RESOURCE_TYPE_SUB_FRAME &&
+                            !IsAcceptedScheme(request->url().spec())))) {

[davidben, 2014/09/29 21:40:44]

Could you add a comment explaining why it's important that only URLs the browser
can't display can be intercepted here?

[Jaekyun Seok (inactive), 2014/09/29 22:17:18]

Yes, I will.

     throttles->push_back(
         InterceptNavigationDelegate::CreateThrottleFor(request));
   }
 #else
   if (resource_type == content::RESOURCE_TYPE_MAIN_FRAME) {
     // Redirect some navigations to apps that have registered matching URL
     // handlers ('url_handlers' in the manifest).
     content::ResourceThrottle* url_to_app_throttle =
         AppUrlRedirector::MaybeCreateThrottleFor(request, io_data);
     if (url_to_app_throttle)
@@ skipping 412 matching lines @@
                                        url_request->GetTotalReceivedBytes()));
   }
 }
 
 // static
 void ChromeResourceDispatcherHostDelegate::
     SetExternalProtocolHandlerDelegateForTesting(
     ExternalProtocolHandler::Delegate* delegate) {
   g_external_protocol_handler_delegate = delegate;
 }