Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 61213012: Invalidate embedded objects in optimized code if it was marked for deoptimization. (Closed)

Created:
7 years, 1 month ago by ulan
Modified:
7 years, 1 month ago
Reviewers:
mvstanton, danno
CC:
v8-dev
Visibility:
Public.

Description

Invalidate embedded objects in optimized code if it was marked for deoptimization. It avoids having dead pointers in code from the time it was marked for deoptimization until it is deoptimized. BUG=320532, v8:2996 TEST=mjsunit/regress/regress-320532.js LOG=Y R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18013

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/mark-compact.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
PTAL https://chromiumcodereview.appspot.com/61213012/diff/30001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/61213012/diff/30001/src/objects.cc#newcode10384 src/objects.cc:10384: it.rinfo()->set_target_object(undefined, SKIP_WRITE_BARRIER); We cannot put smi(0) here because, ...
7 years, 1 month ago (2013-11-19 10:40:26 UTC) #1
mvstanton
DBC: Kind of a nit, but is it necessary to pass the undefined object? Why ...
7 years, 1 month ago (2013-11-19 11:15:02 UTC) #2
ulan
> Why not get it from GetHeap()->undefined_value() in the method. Done. Thanks for suggestion.
7 years, 1 month ago (2013-11-19 11:33:38 UTC) #3
danno
lgtm
7 years, 1 month ago (2013-11-22 12:39:26 UTC) #4
ulan
7 years, 1 month ago (2013-11-22 13:10:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r18013 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698