Issue 609783004: Revert of mojo: Add router for python bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 609783004: Revert of mojo: Add router for python bindings. (Closed)

Created:
6 years, 2 months ago by qsr

Modified:
6 years, 2 months ago

Reviewers:
Chris Masone, sdefresne

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of mojo: Add router for python bindings. (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/607513003/) Reason for revert: Test are failing. Original issue's description: > mojo: Add router for python bindings. > > BUG=417707 > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/5d07d365694ba3e516a861a1018d31e055bfdf39 > Cr-Commit-Position: refs/heads/master@{#296941} TBR=cmasone@chromium.org,sdefresne@chromium.org NOTREECHECKS=true NOTRY=true BUG=417707 Committed: https://crrev.com/3fe4ee45927a9614c9b2848d984d3a2fc3f3e17c Cr-Commit-Position: refs/heads/master@{#296946}

Patch Set 1 #

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -358 lines)			Patch
	M	mojo/public/python/mojo/bindings/messaging.py	View		5 chunks	+0 lines, -220 lines	0 comments	Download
	M	mojo/python/tests/messaging_unittest.py	View		4 chunks	+12 lines, -138 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609783004/1

6 years, 2 months ago (2014-09-26 15:31:59 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 3d97f408780281884626a91a2d7336018eebbb53

6 years, 2 months ago (2014-09-26 15:32:42 UTC) #3

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 15:33:52 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3fe4ee45927a9614c9b2848d984d3a2fc3f3e17c
Cr-Commit-Position: refs/heads/master@{#296946}

Expand Messages | Collapse Messages