chrome/browser/resources/print_preview/settings/layout_settings.js - Issue 606213002: Compile print_preview, part 6: reduce down to 48 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/settings/layout_settings.js

Issue 606213002: Compile print_preview, part 6: reduce down to 48 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@J_print_preview_5

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/color_settings.js ('k') | chrome/browser/resources/print_preview/settings/media_size_settings.js » ('j') | chrome/browser/resources/print_preview/settings/page_settings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/settings/layout_settings.js

diff --git a/chrome/browser/resources/print_preview/settings/layout_settings.js b/chrome/browser/resources/print_preview/settings/layout_settings.js

index af0bbeadf08fd55133f4c4a42d2df7711ea2512b..c919085b2bbbbb8736cc5b41985e114af0e9f4f3 100644

--- a/chrome/browser/resources/print_preview/settings/layout_settings.js

+++ b/chrome/browser/resources/print_preview/settings/layout_settings.js

@@ -46,7 +46,7 @@ cr.define('print_preview', function() {

enterDocument: function() {

print_preview.SettingsSection.prototype.enterDocument.call(this);

this.tracker.add(

- this.select_, 'change', this.onSelectChange_.bind(this));

+ assert(this.select_), 'change', this.onSelectChange_.bind(this));

this.tracker.add(

this.landscapeTicketItem_,

print_preview.ticket_items.TicketItem.EventType.CHANGE,

@@ -70,7 +70,8 @@ cr.define('print_preview', function() {

* @private

get select_() {

- return this.getChildElement('.layout-settings-select');

+ return /** @type {HTMLSelectElement} */(

+ this.getChildElement('.layout-settings-select'));

/**