Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js

Issue 606213002: Compile print_preview, part 6: reduce down to 48 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@J_print_preview_5
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js
diff --git a/chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js b/chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js
index 8b28978123eaa8589368e45d162bad0f7dc76ecb..5315797ad32a99e136f916c6fa9a34b55b07e7df 100644
--- a/chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js
+++ b/chrome/browser/resources/print_preview/data/ticket_items/ticket_item.js
@@ -2,11 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-/**
- * @typedef {Object|number|boolean|string}
- */
-print_preview.ValueType;
-
cr.define('print_preview.ticket_items', function() {
'use strict';
@@ -91,7 +86,7 @@ cr.define('print_preview.ticket_items', function() {
/**
* Determines whether a given value is valid for the ticket item.
- * @param {print_preview.ValueType} value The value to check for validity.
+ * @param {?} value The value to check for validity.
* @return {boolean} Whether the given value is valid for the ticket item.
*/
wouldValueBeValid: function(value) {
@@ -105,7 +100,7 @@ cr.define('print_preview.ticket_items', function() {
throw Error('Abstract method not overridden');
},
- /** @return {print_preview.ValueType} The value of the ticket item. */
+ /** @return {?} The value of the ticket item. */
getValue: function() {
if (this.isCapabilityAvailable()) {
if (this.value_ == null) {
@@ -132,7 +127,7 @@ cr.define('print_preview.ticket_items', function() {
},
/**
- * @param {print_preview.ValueType} value Value to compare to the value of
+ * @param {?} value Value to compare to the value of
* this ticket item.
* @return {boolean} Whether the given value is equal to the value of the
* ticket item.
@@ -142,7 +137,7 @@ cr.define('print_preview.ticket_items', function() {
},
/**
- * @param {print_preview.ValueType} value Value to set as the value of the
+ * @param {?} value Value to set as the value of the
* ticket item.
*/
updateValue: function(value) {
@@ -151,7 +146,7 @@ cr.define('print_preview.ticket_items', function() {
// Don't lose requested value if capability is not available.
this.updateValueInternal(value);
if (this.appState_) {
- this.appState_.persistField(this.field_, value);
+ this.appState_.persistField(assert(this.field_), value);
}
if (sendUpdateEvent)
cr.dispatchSimpleEvent(this, TicketItem.EventType.CHANGE);

Powered by Google App Engine
This is Rietveld 408576698