Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/resources/print_preview/settings/page_settings.js

Issue 606213002: Compile print_preview, part 6: reduce down to 48 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@J_print_preview_5
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/settings/media_size_settings.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('print_preview', function() { 5 cr.define('print_preview', function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * Creates a PageSettings object. This object encapsulates all settings and 9 * Creates a PageSettings object. This object encapsulates all settings and
10 * logic related to page selection. 10 * logic related to page selection.
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 set isEnabled(isEnabled) { 95 set isEnabled(isEnabled) {
96 this.customInput_.disabled = !isEnabled; 96 this.customInput_.disabled = !isEnabled;
97 this.allRadio_.disabled = !isEnabled; 97 this.allRadio_.disabled = !isEnabled;
98 this.customRadio_.disabled = !isEnabled; 98 this.customRadio_.disabled = !isEnabled;
99 }, 99 },
100 100
101 /** @override */ 101 /** @override */
102 enterDocument: function() { 102 enterDocument: function() {
103 print_preview.SettingsSection.prototype.enterDocument.call(this); 103 print_preview.SettingsSection.prototype.enterDocument.call(this);
104 this.tracker.add( 104 this.tracker.add(
105 this.allRadio_, 'click', this.onAllRadioClick_.bind(this)); 105 assert(this.allRadio_), 'click', this.onAllRadioClick_.bind(this));
106 this.tracker.add( 106 this.tracker.add(
107 this.customRadio_, 'click', this.onCustomRadioClick_.bind(this)); 107 assert(this.customRadio_),
108 'click',
109 this.onCustomRadioClick_.bind(this));
108 this.tracker.add( 110 this.tracker.add(
109 this.customInput_, 'blur', this.onCustomInputBlur_.bind(this)); 111 assert(this.customInput_),
112 'blur',
Vitaly Buka (NO REVIEWS) 2014/09/30 01:21:03 shouldn't this be aligned like: this.tracker.add(
Vitaly Pavlenko 2014/10/01 02:19:33 Done.
113 this.onCustomInputBlur_.bind(this));
110 this.tracker.add( 114 this.tracker.add(
111 this.customInput_, 'focus', this.onCustomInputFocus_.bind(this)); 115 assert(this.customInput_),
116 'focus',
117 this.onCustomInputFocus_.bind(this));
112 this.tracker.add( 118 this.tracker.add(
113 this.customInput_, 'keydown', this.onCustomInputKeyDown_.bind(this)); 119 assert(this.customInput_),
120 'keydown',
121 this.onCustomInputKeyDown_.bind(this));
114 this.tracker.add( 122 this.tracker.add(
115 this.customInput_, 'keyup', this.onCustomInputKeyUp_.bind(this)); 123 assert(this.customInput_),
124 'keyup',
125 this.onCustomInputKeyUp_.bind(this));
116 this.tracker.add( 126 this.tracker.add(
117 this.pageRangeTicketItem_, 127 assert(this.pageRangeTicketItem_),
118 print_preview.ticket_items.TicketItem.EventType.CHANGE, 128 print_preview.ticket_items.TicketItem.EventType.CHANGE,
119 this.onPageRangeTicketItemChange_.bind(this)); 129 this.onPageRangeTicketItemChange_.bind(this));
120 }, 130 },
121 131
122 /** @override */ 132 /** @override */
123 exitDocument: function() { 133 exitDocument: function() {
124 print_preview.SettingsSection.prototype.exitDocument.call(this); 134 print_preview.SettingsSection.prototype.exitDocument.call(this);
125 this.customInput_ = null; 135 this.customInput_ = null;
126 this.customRadio_ = null; 136 this.customRadio_ = null;
127 this.allRadio_ = null; 137 this.allRadio_ = null;
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 } 269 }
260 this.updateUiStateInternal(); 270 this.updateUiStateInternal();
261 } 271 }
262 }; 272 };
263 273
264 // Export 274 // Export
265 return { 275 return {
266 PageSettings: PageSettings 276 PageSettings: PageSettings
267 }; 277 };
268 }); 278 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/print_preview/settings/media_size_settings.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698