Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove platform guards. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 42ddc2448e32311b4f5a8b0e616a240fef48224c..73011d58ee3d9b8717e4ed5532778a1b42013885 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -341,8 +341,6 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
const autofill::PasswordForm& form) {
// TODO(gcasto): Validate data in PasswordForm.
- // Not yet implemented on other platforms.
-#if defined(USE_AURA) || defined(OS_MACOSX)
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
popup_controller_ =
@@ -356,15 +354,12 @@ void ChromePasswordManagerClient::ShowPasswordGenerationPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(true /* display_password */);
-#endif // defined(USE_AURA) || defined(OS_MACOSX)
}
void ChromePasswordManagerClient::ShowPasswordEditingPopup(
const gfx::RectF& bounds,
const autofill::PasswordForm& form) {
gfx::RectF element_bounds_in_screen_space = GetBoundsInScreenSpace(bounds);
- // Not yet implemented on other platforms.
-#if defined(USE_AURA) || defined(OS_MACOSX)
popup_controller_ =
autofill::PasswordGenerationPopupControllerImpl::GetOrCreate(
popup_controller_,
@@ -376,7 +371,6 @@ void ChromePasswordManagerClient::ShowPasswordEditingPopup(
web_contents(),
web_contents()->GetNativeView());
popup_controller_->Show(false /* display_password */);
-#endif // defined(USE_AURA) || defined(OS_MACOSX)
}
void ChromePasswordManagerClient::NotifyRendererOfLoggingAvailability() {

Powered by Google App Engine
This is Rietveld 408576698