chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc - Issue 606153002: [android] Password generation UI for android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 606153002: [android] Password generation UI for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unify default text color. Use integers instead of enums. Simplify delegate. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/autofill/PasswordGenerationPopupBridge.java ('K') | « chrome/browser/ui/android/autofill/password_generation_popup_view_android.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

index a2a2c7f924588f0fe188d36aa85dfb3200d71e0f..7e08d781458340e7a86ba2ff8d53e0de3acf7053 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

@@ -214,9 +214,11 @@ void PasswordGenerationPopupControllerImpl::ViewDestroyed() {

}

void PasswordGenerationPopupControllerImpl::OnSavedPasswordsLinkClicked() {

+#if !defined(OS_ANDROID)

aurimas (slooooooooow) 2014/10/16 23:30:01 Are you planning a follow up CL for this?

please use gerrit instead 2014/10/17 05:19:00 Yes, I cannot remove the feature from behind the f

chrome::ShowSettingsSubPage(

chrome::FindBrowserWithWebContents(controller_common_.web_contents()),

chrome::kPasswordManagerSubPage);

+#endif

}

void PasswordGenerationPopupControllerImpl::SetSelectionAtPoint(