Issue 6049007: Create IVerifierStatus and add IVerifierStatus.ignored().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6049007: Create IVerifierStatus and add IVerifierStatus.ignored(). (Closed)

Created:
9 years, 11 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Visibility:
Public.

Description

Create IVerifierStatus and add IVerifierStatus.ignored(). This way, issue filtering can be with a verifier. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71080

Patch Set 2 : Remove processed from PendingCommit and determine its status instead. #

Patch Set 3 : fix diff #

Total comments: 2

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -7 lines)			Patch
M	pending_manager.py	View	1 2	5 chunks	+7 lines, -5 lines	2 comments	Download
M	verification/base.py	View	2	2 chunks	+32 lines, -1 line	0 comments	Download
M	verification/try_server.py	View	2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. http://codereview.chromium.org/6049007/diff/6001/pending_manager.py File pending_manager.py (right): http://codereview.chromium.org/6049007/diff/6001/pending_manager.py#newcode142 pending_manager.py:142: if len(pending.verifications) == len(self.verifiers) or pending.done(): Should this ...

9 years, 11 months ago (2011-01-04 22:10:42 UTC) #3

M-A Ruel

9 years, 11 months ago (2011-01-11 21:07:40 UTC) #4

http://codereview.chromium.org/6049007/diff/6001/pending_manager.py
File pending_manager.py (right):

http://codereview.chromium.org/6049007/diff/6001/pending_manager.py#newcode142
pending_manager.py:142: if len(pending.verifications) == len(self.verifiers) or
pending.done():
On 2011/01/04 22:10:42, dpranke wrote:
> Should this check maybe be part of pending.done() (or a different method on
> pending, e.g., verified())?

That's a good question.

Since pending doesn't know the number of verifiers, it's hard to have a member
function verify that so I don't know what could be done instead in a code
efficient way.