chrome/browser/resources/options/options.js - Issue 604373006: Compile chrome://settings, part 9: yet another final battle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/options.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks

Patch Set: dbeam@'s review Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/controlled_setting.js ('k') | chrome/browser/resources/options/preferences.js » ('j') | chrome/browser/resources/sync_setup_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/options.js

diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js

index 9d62c10d60208d67ca30320a59bc397c2f4756cb..c3f5862768fc760aa9378c2772d7622943b1b74d 100644

--- a/chrome/browser/resources/options/options.js

+++ b/chrome/browser/resources/options/options.js

@@ -92,8 +92,8 @@ function load() {

'doNotTrackConfirm',

loadTimeData.getString('doNotTrackConfirmOverlayTabTitle'),

'do-not-track-confirm-overlay',

- /** @type {HTMLInputElement} */($('do-not-track-confirm-ok')),

- /** @type {HTMLInputElement} */($('do-not-track-confirm-cancel')),

+ /** @type {HTMLButtonElement} */($('do-not-track-confirm-ok')),

+ /** @type {HTMLButtonElement} */($('do-not-track-confirm-cancel')),

$('do-not-track-enabled')['pref'],

$('do-not-track-enabled')['metric']),

BrowserOptions.getInstance());

@@ -105,8 +105,8 @@ function load() {

'spellingConfirm',

loadTimeData.getString('spellingConfirmOverlayTabTitle'),

'spelling-confirm-overlay',

- /** @type {HTMLInputElement} */($('spelling-confirm-ok')),

- /** @type {HTMLInputElement} */($('spelling-confirm-cancel')),

+ /** @type {HTMLButtonElement} */($('spelling-confirm-ok')),

+ /** @type {HTMLButtonElement} */($('spelling-confirm-cancel')),

$('spelling-enabled-control')['pref'],

$('spelling-enabled-control')['metric']),

BrowserOptions.getInstance());