ui/webui/resources/js/cr/ui/touch_handler.js - Issue 604373006: Compile chrome://settings, part 9: yet another final battle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/touch_handler.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/reset_profile_settings_banner.js ('K') | « ui/webui/resources/js/cr/ui/list.js ('k') | ui/webui/resources/js/util.js » ('j') | ui/webui/resources/js/util.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/touch_handler.js

diff --git a/ui/webui/resources/js/cr/ui/touch_handler.js b/ui/webui/resources/js/cr/ui/touch_handler.js

index acc12afe1f5df22177c23106e0bc89487927cace..67f83f766e2f83f4317af8f1f3d9f5a7f7a89efa 100644

--- a/ui/webui/resources/js/cr/ui/touch_handler.js

+++ b/ui/webui/resources/js/cr/ui/touch_handler.js

@@ -788,6 +788,8 @@ cr.define('cr.ui', function() {

this.disableTap_ = true;

// Dispatch to the LONG_PRESS

+ assert(this.startTouchX_ !== undefined);

+ assert(this.startTouchY_ !== undefined);

Dan Beam 2014/10/01 01:25:57 nit: assert(typeof this.startTouchY_ == 'number');

Vitaly Pavlenko 2014/10/01 03:07:31 Done.

this.dispatchEventXY_(TouchHandler.EventType.LONG_PRESS, this.element_,

/** @type {number} */(this.startTouchX_),

/** @type {number} */(this.startTouchY_));