Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5405)

Unified Diff: chrome/browser/resources/options/controlled_setting.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/controlled_setting.js
diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js
index df428faea98fc5c99c450b330199696aa81e60be..e75c4134920ffe51975f610b300a4bf08cfbf01d 100644
--- a/chrome/browser/resources/options/controlled_setting.js
+++ b/chrome/browser/resources/options/controlled_setting.js
@@ -55,6 +55,8 @@ cr.define('options', function() {
* Handle changes to the associated pref by hiding any currently visible
* bubble and updating the controlledBy property.
* @param {Event} event Pref change event.
+ * @suppress {checkTypes}
+ * TODO(vitalyp): remove the suppression.
Dan Beam 2014/10/01 23:25:45 why?
Vitaly Pavlenko 2014/10/01 23:38:17 this.controlledBy defined as cr.defineProperty(),
*/
handlePrefChange: function(event) {
PageManager.hideBubble();

Powered by Google App Engine
This is Rietveld 408576698