Compile chrome://settings, part 9: yet another final battle

chrome/browser/resources/options/alert_overlay.js

Index: chrome/browser/resources/options/alert_overlay.js
diff --git a/chrome/browser/resources/options/alert_overlay.js b/chrome/browser/resources/options/alert_overlay.js
index cd7aaf36a093207d6206c41a33652162cd8f892d..2206517d08003057a039a9f15fb00e092222e16a 100644
--- a/chrome/browser/resources/options/alert_overlay.js
+++ b/chrome/browser/resources/options/alert_overlay.js
@@ -75,7 +75,7 @@ cr.define('options', function() {
      * @override
      */
     willHidePage: function() {
-      canShow_ = false;
+      this.canShow_ = false;

[Dan Beam, 2014/10/01 01:25:57]

whhhhhhat

[Vitaly Pavlenko, 2014/10/01 03:07:31]

It's hard to understand who actually added this line to source.

[Dan Beam, 2014/10/01 23:25:45]

https://codereview.chromium.org/6480039/diff/2004/chrome/browser/resources/op...

     },
 
     /** @override */
@@ -93,10 +93,10 @@ cr.define('options', function() {
    *     no button is shown.
    * @param {string} cancelTitle The title of the cancel button. If undefined or
    *     empty, no button is shown.
-   * @param {function} okCallback A function to be called when the user presses
-   *     the ok button.  The alert window will be closed automatically.  Can be
-   *     undefined.
-   * @param {function} cancelCallback A function to be called when the user
+   * @param {function()} okCallback A function to be called when the user
+   *     presses the ok button.  The alert window will be closed automatically.
+   *     Can be undefined.
+   * @param {function()} cancelCallback A function to be called when the user
    *     presses the cancel button.  The alert window will be closed
    *     automatically.  Can be undefined.
    */