Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: chrome/browser/resources/options/chromeos/internet_detail.js

Issue 604373006: Compile chrome://settings, part 9: yet another final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@K_blockers_from_bookmarks
Patch Set: describe supressions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // require: onc_data.js 5 // require: onc_data.js
6 6
7 // NOTE(stevenjb): This code is in the process of being converted to be 7 // NOTE(stevenjb): This code is in the process of being converted to be
8 // compatible with the networkingPrivate extension API: 8 // compatible with the networkingPrivate extension API:
9 // * The network property dictionaries are being converted to use ONC values. 9 // * The network property dictionaries are being converted to use ONC values.
10 // * chrome.send calls will be replaced with an API object that simulates the 10 // * chrome.send calls will be replaced with an API object that simulates the
(...skipping 1172 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 detailsPage.showCarrierSelect_ = info.showCarrierSelect; 1183 detailsPage.showCarrierSelect_ = info.showCarrierSelect;
1184 detailsPage.showViewAccountButton_ = info.showViewAccountButton; 1184 detailsPage.showViewAccountButton_ = info.showViewAccountButton;
1185 // Ask Chrome to call sendNetworkDetails with the ONC properties. 1185 // Ask Chrome to call sendNetworkDetails with the ONC properties.
1186 // TODO(stevenjb): Use networkingPrivate.getManagedProperties(info.guid). 1186 // TODO(stevenjb): Use networkingPrivate.getManagedProperties(info.guid).
1187 chrome.send('getManagedProperties', [info.servicePath]); 1187 chrome.send('getManagedProperties', [info.servicePath]);
1188 }; 1188 };
1189 1189
1190 /** 1190 /**
1191 * Method called from Chrome when the ONC properties for the displayed 1191 * Method called from Chrome when the ONC properties for the displayed
1192 * network may have changed. 1192 * network may have changed.
1193 * @param {Object} update The updated ONC dictionary for the network. 1193 * @param {Object} oncData The updated ONC dictionary for the network.
1194 */ 1194 */
1195 DetailsInternetPage.updateConnectionData = function(oncData) { 1195 DetailsInternetPage.updateConnectionData = function(oncData) {
1196 var detailsPage = DetailsInternetPage.getInstance(); 1196 var detailsPage = DetailsInternetPage.getInstance();
1197 if (!detailsPage.visible) 1197 if (!detailsPage.visible)
1198 return; 1198 return;
1199 1199
1200 if (oncData.servicePath != detailsPage.servicePath_) 1200 if (oncData.servicePath != detailsPage.servicePath_)
1201 return; 1201 return;
1202 1202
1203 // Update our cached data object. 1203 // Update our cached data object.
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 1598
1599 // Don't show page name in address bar and in history to prevent people 1599 // Don't show page name in address bar and in history to prevent people
1600 // navigate here by hand and solve issue with page session restore. 1600 // navigate here by hand and solve issue with page session restore.
1601 PageManager.showPageByName('detailsInternetPage', false); 1601 PageManager.showPageByName('detailsInternetPage', false);
1602 }; 1602 };
1603 1603
1604 return { 1604 return {
1605 DetailsInternetPage: DetailsInternetPage 1605 DetailsInternetPage: DetailsInternetPage
1606 }; 1606 };
1607 }); 1607 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | chrome/browser/resources/options/chromeos/network_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698