Compile chrome://settings, part 9: yet another final battle

ui/webui/resources/js/util.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="assert.js">
 
 /**
  * Alias for document.getElementById.
  * @param {string} id The ID of the element to find.
  * @return {HTMLElement} The found element or null if not found.
@@ skipping 236 matching lines @@
  */
 function isRTL() {
   return document.documentElement.dir == 'rtl';
 }
 
 /**
  * Get an element that's known to exist by its ID. We use this instead of just
  * calling getElementById and not checking the result because this lets us
  * satisfy the JSCompiler type system.
  * @param {string} id The identifier name.
- * @return {!Element} the Element.
+ * @return {!HTMLElement} the Element.
  */
 function getRequiredElement(id) {
   var element = $(id);
   assert(element, 'Missing required element: ' + id);

[Dan Beam, 2014/10/01 01:25:57]

why does the rest of this method exist now?

[Vitaly Pavlenko, 2014/10/01 03:07:32]

Done.

-  return /** @type {!Element} */(element);
+  return assertInstanceof($(id), HTMLElement,
+                          'Missing required element: ' + id);
 }
 
 // Handle click on a link. If the link points to a chrome: or file: url, then
 // call into the browser to do the navigation.
 document.addEventListener('click', function(e) {
   if (e.defaultPrevented)
     return;
 
   var el = e.target;
   if (el.nodeType == Node.ELEMENT_NODE &&
@@ skipping 159 matching lines @@
  * @param {number} maxLength The maximum length allowed for the string.
  * @return {string} The original string if its length does not exceed
  *     |maxLength|. Otherwise the first |maxLength| - 1 characters with '...'
  *     appended.
  */
 function elide(original, maxLength) {
   if (original.length <= maxLength)
     return original;
   return original.substring(0, maxLength - 1) + '\u2026';
 }