Compile chrome://settings, part 9: yet another final battle

chrome/browser/resources/options/controlled_setting.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Preferences = options.Preferences;
 
   /**
    * A controlled setting indicator that can be placed on a setting as an
    * indicator that the value is controlled by some external entity such as
@@ skipping 37 matching lines @@
      * @private
      */
     clearAssociatedPref_: function() {
       Preferences.clearPref(this.pref, !this.dialogPref);
     },
 
     /**
      * Handle changes to the associated pref by hiding any currently visible
      * bubble and updating the controlledBy property.
      * @param {Event} event Pref change event.
+     * @suppress {checkTypes}
+     * TODO(vitalyp): remove the suppression.

[Dan Beam, 2014/10/01 23:25:45]

why?

[Vitaly Pavlenko, 2014/10/01 23:38:17]

this.controlledBy defined as cr.defineProperty(), so compiler thinks it's a
string. But in fact, it's a nullable string, and it needs some refactoring to
make it be non-nullable.

Do you think we should do that right now?

      */
     handlePrefChange: function(event) {
       PageManager.hideBubble();
       if (event.value.controlledBy) {
         if (!this.value || String(event.value.value) == this.value) {
           this.controlledBy = event.value.controlledBy;
           if (event.value.extension) {
             this.extensionId = event.value.extension.id;
             this.extensionIcon = event.value.extension.icon;
             this.extensionName = event.value.extension.name;
@@ skipping 158 matching lines @@
    * - unset:               The value is controlled by the user alone.
    */
   cr.defineProperty(ControlledSettingIndicator, 'controlledBy',
                     cr.PropertyKind.ATTR);
 
   // Export.
   return {
     ControlledSettingIndicator: ControlledSettingIndicator
   };
 });