Compile chrome://settings, part 9: yet another final battle

chrome/browser/resources/options/chromeos/network_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @typedef {{
  *   ConnectionState: string,
  *   iconURL: string,
  *   policyManaged: boolean,
  *   servicePath: string
@@ skipping 57 matching lines @@
 
   /**
    * Indicates if cellular device supports network scanning.
    * @type {boolean}
    * @private
    */
   var cellularSupportsScan_ = false;
 
   /**
    * Indicates the current SIM lock type of the cellular device.
-   * @type {boolean}
+   * @type {string}
    * @private
    */
   var cellularSimLockType_ = '';
 
   /**
    * Indicates whether the SIM card is absent on the cellular device.
    * @type {boolean}
    * @private
    */
   var cellularSimAbsent_ = false;
@@ skipping 853 matching lines @@
       if (entry.networkList)
         return new NetworkSelectorItem(
             /** @type {{key: string, networkList: Array.<NetworkInfo>}} */(
                 entry));
       if (entry.command)
         return new NetworkButtonItem(
             /** @type {{key: string, subtitle: string, command: Function}} */(
                 entry));
       if (entry.menu)
         return new NetworkMenuItem(entry);
-      return undefined;
+      assertNotReached();

[Dan Beam, 2014/10/01 01:25:57]

how do we know this isn't being hit?

[Vitaly Pavlenko, 2014/10/01 03:07:31]

We'll see on try bots if it is being hit or not. I don't get you, probably.

     },
 
     /**
      * Deletes an element from the list.
      * @param {string} key  Unique identifier for the element.
      */
     deleteItem: function(key) {
       var index = this.indexOf(key);
       if (index != undefined)
         this.dataModel.splice(index, 1);
@@ skipping 19 matching lines @@
    * Sets the default icon to use for each network type if disconnected.
    * @param {!Object.<string, string>} data Mapping of network type to icon
    *     data url.
    */
   NetworkList.setDefaultNetworkIcons = function(data) {
     defaultIcons_ = Object.create(data);
   };
 
   /**
    * Chrome callback for updating network controls.
-   * @param {{wiredList: Array.<NetworkInfo>, wirelessList: Array.<NetworkInfo>,
-   *     vpnList: Array.<NetworkInfo>, rememberedList: Array.<NetworkInfo>,
-   *     wifiAvailable: boolean, wifiEnabled: boolean, wimaxAvailable: boolean,
-   *     wimaxEnabled: boolean, cellularAvailable: boolean,
-   *     cellularEnabled: boolean, cellularSupportsScan: boolean}} data
-   *     Description of available network devices and their corresponding state.
+   * @param {{cellularAvailable: boolean,
+   *          cellularEnabled: boolean,
+   *          cellularSimAbsent: boolean,
+   *          cellularSimLockType: string,
+   *          cellularSupportsScan: boolean,
+   *          rememberedList: Array.<NetworkInfo>,
+   *          vpnList: Array.<NetworkInfo>,
+   *          wifiAvailable: boolean,
+   *          wifiEnabled: boolean,
+   *          wimaxAvailable: boolean,
+   *          wimaxEnabled: boolean,
+   *          wiredList: Array.<NetworkInfo>,
+   *          wirelessList: Array.<NetworkInfo>}} data Description of available
+   *     network devices and their corresponding state.
    */
   NetworkList.refreshNetworkData = function(data) {
     var networkList = $('network-list');
     networkList.startBatchUpdates();
     cellularAvailable_ = data.cellularAvailable;
     cellularEnabled_ = data.cellularEnabled;
     cellularSupportsScan_ = data.cellularSupportsScan;
     cellularSimAbsent_ = data.cellularSimAbsent;
     cellularSimLockType_ = data.cellularSimLockType;
     wimaxAvailable_ = data.wimaxAvailable;
@@ skipping 213 matching lines @@
   /**
    * Whether the Network list is disabled. Only used for display purpose.
    */
   cr.defineProperty(NetworkList, 'disabled', cr.PropertyKind.BOOL_ATTR);
 
   // Export
   return {
     NetworkList: NetworkList
   };
 });