Compile chrome://settings, part 9: yet another final battle

chrome/browser/resources/options/alert_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
 
   /**
    * AlertOverlay class
@@ skipping 57 matching lines @@
       if (this.cancelCallback != undefined) {
         this.cancelCallback.call();
       }
     },
 
     /**
      * The page is getting hidden. Don't let it be shown again.
      * @override
      */
     willHidePage: function() {
-      canShow_ = false;
+      this.canShow_ = false;

[Dan Beam, 2014/10/01 01:25:57]

whhhhhhat

[Vitaly Pavlenko, 2014/10/01 03:07:31]

It's hard to understand who actually added this line to source.

[Dan Beam, 2014/10/01 23:25:45]

https://codereview.chromium.org/6480039/diff/2004/chrome/browser/resources/op...

     },
 
     /** @override */
     canShowPage: function() {
       return this.canShow_;
     },
   };
 
   /**
    * Show an alert overlay with the given message, button titles, and
    * callbacks.
    * @param {string} title The alert title to display to the user.
    * @param {string} message The alert message to display to the user.
    * @param {string} okTitle The title of the OK button. If undefined or empty,
    *     no button is shown.
    * @param {string} cancelTitle The title of the cancel button. If undefined or
    *     empty, no button is shown.
-   * @param {function} okCallback A function to be called when the user presses
-   *     the ok button.  The alert window will be closed automatically.  Can be
-   *     undefined.
-   * @param {function} cancelCallback A function to be called when the user
+   * @param {function()} okCallback A function to be called when the user
+   *     presses the ok button.  The alert window will be closed automatically.
+   *     Can be undefined.
+   * @param {function()} cancelCallback A function to be called when the user
    *     presses the cancel button.  The alert window will be closed
    *     automatically.  Can be undefined.
    */
   AlertOverlay.show = function(
       title, message, okTitle, cancelTitle, okCallback, cancelCallback) {
     if (title != undefined) {
       $('alertOverlayTitle').textContent = title;
       $('alertOverlayTitle').style.display = 'block';
     } else {
       $('alertOverlayTitle').style.display = 'none';
@@ skipping 28 matching lines @@
     // Intentionally don't show the URL in the location bar as we don't want
     // people trying to navigate here by hand.
     PageManager.showPageByName('alertOverlay', false);
   };
 
   // Export
   return {
     AlertOverlay: AlertOverlay
   };
 });