Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 60233005: Remove WIP label, make categories always expanded, move build number down. (Closed)

Created:
7 years, 1 month ago by Alan Knight
Modified:
7 years, 1 month ago
Reviewers:
Emily Fortuna
Base URL:
https://github.com/dart-lang/dartdoc-viewer.git@master
Visibility:
Public.

Description

Remove WIP label, make categories always expanded, move build number down. R=efortuna@google.com Committed: https://github.com/dart-lang/dartdoc-viewer/commit/494ed83

Patch Set 1 #

Total comments: 1

Patch Set 2 : Go back to collapsing when small, panel and minimap vanish at the same time column widens #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M client/web/app.dart View 1 chunk +1 line, -1 line 0 comments Download
M client/web/category.dart View 1 2 chunks +0 lines, -4 lines 0 comments Download
M client/web/category.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M client/web/library-panel.html View 1 1 chunk +1 line, -1 line 0 comments Download
M client/web/main.html View 2 chunks +3 lines, -2 lines 0 comments Download
M client/web/minimap-class.html View 1 1 chunk +1 line, -1 line 0 comments Download
M client/web/minimap-library.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alan Knight
7 years, 1 month ago (2013-11-05 20:03:43 UTC) #1
Emily Fortuna
https://chromiumcodereview.appspot.com/60233005/diff/1/client/web/category.dart File client/web/category.dart (right): https://chromiumcodereview.appspot.com/60233005/diff/1/client/web/category.dart#newcode119 client/web/category.dart:119: accordionStyleFor(isDesktop) => ''; I disagree with this change, but ...
7 years, 1 month ago (2013-11-05 20:16:06 UTC) #2
Alan Knight
Reverted that part of it, got rid of the problem where the panel and minimap ...
7 years, 1 month ago (2013-11-05 21:53:44 UTC) #3
Emily Fortuna
lgtm
7 years, 1 month ago (2013-11-05 22:20:19 UTC) #4
Alan Knight
7 years, 1 month ago (2013-11-05 22:47:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r494ed83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698