Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2866)

Unified Diff: runtime/vm/stub_code.cc

Issue 600243002: Patchable AllocateArray stub, like instance allocation stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stub_code.h ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code.cc
===================================================================
--- runtime/vm/stub_code.cc (revision 40629)
+++ runtime/vm/stub_code.cc (working copy)
@@ -9,6 +9,7 @@
#include "vm/assembler.h"
#include "vm/disassembler.h"
#include "vm/flags.h"
+#include "vm/object_store.h"
#include "vm/virtual_memory.h"
#include "vm/visitor.h"
@@ -67,7 +68,7 @@
void StubCode::Init(Isolate* isolate) {
- StubCode* stubs = new StubCode();
+ StubCode* stubs = new StubCode(isolate);
isolate->set_stub_code(stubs);
stubs->GenerateFor(isolate);
}
@@ -110,6 +111,13 @@
}
+RawCode* StubCode::GetAllocateArrayStub() {
+ const Class& array_cls = Class::Handle(isolate_,
+ isolate_->object_store()->array_class());
+ return GetAllocationStubForClass(array_cls);
+}
+
+
RawCode* StubCode::GetAllocationStubForClass(const Class& cls) {
Isolate* isolate = Isolate::Current();
const Error& error = Error::Handle(isolate, cls.EnsureIsFinalized(isolate));
@@ -120,8 +128,13 @@
const char* name = cls.ToCString();
uword patch_code_offset = 0;
uword entry_patch_offset = 0;
- StubCode::GenerateAllocationStubForClass(
- &assembler, cls, &entry_patch_offset, &patch_code_offset);
+ if (cls.id() == kArrayCid) {
+ StubCode::GeneratePatchableAllocateArrayStub(
+ &assembler, &entry_patch_offset, &patch_code_offset);
+ } else {
+ StubCode::GenerateAllocationStubForClass(
+ &assembler, cls, &entry_patch_offset, &patch_code_offset);
+ }
stub ^= Code::FinalizeCode(name, &assembler);
stub.set_owner(cls);
cls.set_allocation_stub(stub);
« no previous file with comments | « runtime/vm/stub_code.h ('k') | runtime/vm/stub_code_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698