Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Unified Diff: runtime/vm/instructions_ia32_test.cc

Issue 600243002: Patchable AllocateArray stub, like instance allocation stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_mips_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_ia32_test.cc
===================================================================
--- runtime/vm/instructions_ia32_test.cc (revision 40629)
+++ runtime/vm/instructions_ia32_test.cc (working copy)
@@ -34,7 +34,9 @@
ASSEMBLER_TEST_GENERATE(Jump, assembler) {
StubCode* stub_code = Isolate::Current()->stub_code();
__ jmp(&stub_code->InvokeDartCodeLabel());
- __ jmp(&stub_code->AllocateArrayLabel());
+ const Code& array_stub = Code::Handle(stub_code->GetAllocateArrayStub());
+ const ExternalLabel array_label(array_stub.EntryPoint());
+ __ jmp(&array_label);
__ ret();
}
@@ -53,13 +55,14 @@
jump1.TargetAddress());
JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
test->code());
- EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
+ const Code& array_stub = Code::Handle(stub_code->GetAllocateArrayStub());
+ EXPECT_EQ(array_stub.EntryPoint(),
jump2.TargetAddress());
uword target1 = jump1.TargetAddress();
uword target2 = jump2.TargetAddress();
jump1.SetTargetAddress(target2);
jump2.SetTargetAddress(target1);
- EXPECT_EQ(stub_code->AllocateArrayLabel().address(),
+ EXPECT_EQ(array_stub.EntryPoint(),
jump1.TargetAddress());
EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
jump2.TargetAddress());
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_mips_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698