Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Side by Side Diff: runtime/vm/instructions_arm_test.cc

Issue 600243002: Patchable AllocateArray stub, like instance allocation stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/instructions_arm64_test.cc ('k') | runtime/vm/instructions_ia32_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/cpu.h" 9 #include "vm/cpu.h"
10 #include "vm/instructions.h" 10 #include "vm/instructions.h"
(...skipping 19 matching lines...) Expand all
30 test->code()); 30 test->code());
31 StubCode* stub_code = Isolate::Current()->stub_code(); 31 StubCode* stub_code = Isolate::Current()->stub_code();
32 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(), 32 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
33 call.TargetAddress()); 33 call.TargetAddress());
34 } 34 }
35 35
36 36
37 ASSEMBLER_TEST_GENERATE(Jump, assembler) { 37 ASSEMBLER_TEST_GENERATE(Jump, assembler) {
38 StubCode* stub_code = Isolate::Current()->stub_code(); 38 StubCode* stub_code = Isolate::Current()->stub_code();
39 __ BranchPatchable(&stub_code->InvokeDartCodeLabel()); 39 __ BranchPatchable(&stub_code->InvokeDartCodeLabel());
40 __ BranchPatchable(&stub_code->AllocateArrayLabel()); 40 const Code& array_stub = Code::Handle(stub_code->GetAllocateArrayStub());
41 const ExternalLabel array_label(array_stub.EntryPoint());
42 __ BranchPatchable(&array_label);
41 } 43 }
42 44
43 45
44 ASSEMBLER_TEST_RUN(Jump, test) { 46 ASSEMBLER_TEST_RUN(Jump, test) {
45 const Code& code = test->code(); 47 const Code& code = test->code();
46 const Instructions& instrs = Instructions::Handle(code.instructions()); 48 const Instructions& instrs = Instructions::Handle(code.instructions());
47 bool status = 49 bool status =
48 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()), 50 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
49 instrs.size(), 51 instrs.size(),
50 VirtualMemory::kReadWrite); 52 VirtualMemory::kReadWrite);
51 StubCode* stub_code = Isolate::Current()->stub_code(); 53 StubCode* stub_code = Isolate::Current()->stub_code();
52 EXPECT(status); 54 EXPECT(status);
53 JumpPattern jump1(test->entry(), test->code()); 55 JumpPattern jump1(test->entry(), test->code());
54 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(), 56 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
55 jump1.TargetAddress()); 57 jump1.TargetAddress());
56 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(), 58 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
57 test->code()); 59 test->code());
58 EXPECT_EQ(stub_code->AllocateArrayLabel().address(), 60 const Code& array_stub = Code::Handle(stub_code->GetAllocateArrayStub());
59 jump2.TargetAddress()); 61 EXPECT_EQ(array_stub.EntryPoint(), jump2.TargetAddress());
60 uword target1 = jump1.TargetAddress(); 62 uword target1 = jump1.TargetAddress();
61 uword target2 = jump2.TargetAddress(); 63 uword target2 = jump2.TargetAddress();
62 jump1.SetTargetAddress(target2); 64 jump1.SetTargetAddress(target2);
63 jump2.SetTargetAddress(target1); 65 jump2.SetTargetAddress(target1);
64 EXPECT_EQ(stub_code->AllocateArrayLabel().address(), 66 EXPECT_EQ(array_stub.EntryPoint(), jump1.TargetAddress());
65 jump1.TargetAddress());
66 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(), 67 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
67 jump2.TargetAddress()); 68 jump2.TargetAddress());
68 } 69 }
69 70
70 71
71 #if defined(USING_SIMULATOR) 72 #if defined(USING_SIMULATOR)
72 ASSEMBLER_TEST_GENERATE(JumpARMv6, assembler) { 73 ASSEMBLER_TEST_GENERATE(JumpARMv6, assembler) {
73 // ARMv7 is the default. 74 // ARMv7 is the default.
74 StubCode* stub_code = Isolate::Current()->stub_code(); 75 StubCode* stub_code = Isolate::Current()->stub_code();
75 HostCPUFeatures::set_arm_version(ARMv6); 76 HostCPUFeatures::set_arm_version(ARMv6);
76 __ BranchPatchable(&stub_code->InvokeDartCodeLabel()); 77 __ BranchPatchable(&stub_code->InvokeDartCodeLabel());
77 __ BranchPatchable(&stub_code->AllocateArrayLabel()); 78 const Code& array_stub = Code::Handle(stub_code->GetAllocateArrayStub());
79 const ExternalLabel array_label(array_stub.EntryPoint());
80 __ BranchPatchable(&array_label);
78 HostCPUFeatures::set_arm_version(ARMv7); 81 HostCPUFeatures::set_arm_version(ARMv7);
79 } 82 }
80 83
81 84
82 ASSEMBLER_TEST_RUN(JumpARMv6, test) { 85 ASSEMBLER_TEST_RUN(JumpARMv6, test) {
83 HostCPUFeatures::set_arm_version(ARMv6); 86 HostCPUFeatures::set_arm_version(ARMv6);
84 const Code& code = test->code(); 87 const Code& code = test->code();
85 const Instructions& instrs = Instructions::Handle(code.instructions()); 88 const Instructions& instrs = Instructions::Handle(code.instructions());
86 bool status = 89 bool status =
87 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()), 90 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
88 instrs.size(), 91 instrs.size(),
89 VirtualMemory::kReadWrite); 92 VirtualMemory::kReadWrite);
90 StubCode* stub_code = Isolate::Current()->stub_code(); 93 StubCode* stub_code = Isolate::Current()->stub_code();
91 EXPECT(status); 94 EXPECT(status);
92 JumpPattern jump1(test->entry(), test->code()); 95 JumpPattern jump1(test->entry(), test->code());
93 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(), 96 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
94 jump1.TargetAddress()); 97 jump1.TargetAddress());
95 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(), 98 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
96 test->code()); 99 test->code());
97 EXPECT_EQ(stub_code->AllocateArrayLabel().address(), 100 const Code& array_stub = Code::Handle(stub_code->GetAllocateArrayStub());
98 jump2.TargetAddress()); 101 EXPECT_EQ(array_stub.EntryPoint(), jump2.TargetAddress());
99 uword target1 = jump1.TargetAddress(); 102 uword target1 = jump1.TargetAddress();
100 uword target2 = jump2.TargetAddress(); 103 uword target2 = jump2.TargetAddress();
101 jump1.SetTargetAddress(target2); 104 jump1.SetTargetAddress(target2);
102 jump2.SetTargetAddress(target1); 105 jump2.SetTargetAddress(target1);
103 EXPECT_EQ(stub_code->AllocateArrayLabel().address(), 106 EXPECT_EQ(array_stub.EntryPoint(), jump1.TargetAddress());
104 jump1.TargetAddress());
105 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(), 107 EXPECT_EQ(stub_code->InvokeDartCodeLabel().address(),
106 jump2.TargetAddress()); 108 jump2.TargetAddress());
107 HostCPUFeatures::set_arm_version(ARMv7); 109 HostCPUFeatures::set_arm_version(ARMv7);
108 } 110 }
109 #endif 111 #endif
110 112
111 } // namespace dart 113 } // namespace dart
112 114
113 #endif // defined TARGET_ARCH_ARM 115 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/instructions_arm64_test.cc ('k') | runtime/vm/instructions_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698