Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 59753006: Added dart:js samples landing pages. (Closed)

Created:
7 years, 1 month ago by shailentuli
Modified:
7 years, 1 month ago
Reviewers:
Kathy Walrath
Base URL:
https://github.com/dart-lang/dartlang.org.git@master
Visibility:
Public.

Description

Added dart:js samples landing pages. Also fixed a couple of broken links. R=kathyw@google.com Committed: c31ec08

Patch Set 1 #

Patch Set 2 : Using https for links #

Total comments: 4

Patch Set 3 : Post lgtm tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13363 lines, -7542 lines) Patch
M src/site/samples/gauge/example/gauge.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/site/samples/gauge/example/gauge.dart.js View 1 2 8 chunks +7399 lines, -3251 lines 0 comments Download
A + src/site/samples/gauge/example/gauge.dart.js.deps View 1 2 1 chunk +1 line, -1 line 0 comments Download
A src/site/samples/gauge/example/gauge.dart.js.map View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A + src/site/samples/gauge/example/gauge.dart.precompiled.js View 1 2 160 chunks +5839 lines, -4272 lines 0 comments Download
A src/site/samples/gauge/index.markdown View 2 1 chunk +30 lines, -0 lines 0 comments Download
A src/site/samples/google_maps/index.markdown View 2 1 chunk +32 lines, -0 lines 0 comments Download
M src/site/samples/jsonp/example/index.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A src/site/samples/jsonp/index.markdown View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M src/site/samples/samples.css View 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/site/samples/samples.yaml View 2 4 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shailentuli
https://dartjs-dot-dart-lang.appspot.com/samples/ PTAL.
7 years, 1 month ago (2013-11-05 23:15:13 UTC) #1
shailentuli
Staged version works now. Can you PTAL?
7 years, 1 month ago (2013-11-06 12:42:42 UTC) #2
Kathy Walrath
lgtm I should make a copyedit pass at some point. But here are a few ...
7 years, 1 month ago (2013-11-06 17:48:25 UTC) #3
shailentuli
7 years, 1 month ago (2013-11-06 18:27:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as rc31ec08 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698