content/common/gpu/media/v4l2_video_device.cc - Issue 597473002: Change log level to show real errors in release mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_device.cc

Issue 597473002: Change log level to show real errors in release mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Pawel's review comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/v4l2_video_decode_accelerator.cc ('k') | content/common/gpu/media/v4l2_video_encode_accelerator.cc » ('j') | content/common/gpu/media/vaapi_wrapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_video_device.cc

diff --git a/content/common/gpu/media/v4l2_video_device.cc b/content/common/gpu/media/v4l2_video_device.cc

index 0a094ba6e47d143bb36b7b602094cfb4d73fff44..f62e264d806e3eb63925861368842434b5dedd65 100644

--- a/content/common/gpu/media/v4l2_video_device.cc

+++ b/content/common/gpu/media/v4l2_video_device.cc

@@ -24,7 +24,7 @@ scoped_ptr<V4L2Device> V4L2Device::Create(Type type) {

if (tegra_device->Initialize())

return tegra_device.PassAs<V4L2Device>();

- DLOG(ERROR) << "Failed to create V4L2Device";

+ LOG(ERROR) << "Failed to create V4L2Device";

return scoped_ptr<V4L2Device>();

}

@@ -113,7 +113,7 @@ gfx::Size V4L2Device::CodedSizeFromV4L2Format(struct v4l2_format format) {

<< ", horiz_bpp=" << horiz_bpp;

if (sizeimage == 0 || bytesperline == 0 || horiz_bpp == 0 ||

(bytesperline * 8) % horiz_bpp != 0) {

- DLOG(ERROR) << "Invalid format provided";

+ LOG(ERROR) << "Invalid format provided";

return coded_size;

}