Issue 59743008: Refactor lexer-shell: extract functions to run scanners, to print tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59743008: Refactor lexer-shell: extract functions to run scanners, to print tokens. (Closed)

Created:
7 years, 1 month ago by ulan

Modified:
7 years, 1 month ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Refactor lexer-shell: extract functions to run scanners, to print tokens. This also allows to run scanner without pushing tokens to a vector. BUG= R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17558

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -61 lines)			Patch
	M	src/lexer/lexer-shell.cc	View	1	3 chunks	+104 lines, -61 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

marja

lgtm with comment https://chromiumcodereview.appspot.com/59743008/diff/1/src/lexer/lexer-shell.cc File src/lexer/lexer-shell.cc (right): https://chromiumcodereview.appspot.com/59743008/diff/1/src/lexer/lexer-shell.cc#newcode283 src/lexer/lexer-shell.cc:283: if (run_baseline) { run_experimental

7 years, 1 month ago (2013-11-07 11:52:21 UTC) #2

ulan

7 years, 1 month ago (2013-11-07 12:13:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17558 (presubmit successful).

Expand Messages | Collapse Messages