Issue 59693004: CQ: add a timeout for socket operations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59693004: CQ: add a timeout for socket operations (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years, 1 month ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, cmp-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

More Reviews

Description

CQ: add a timeout for socket operations BUG=314388 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=233167

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	commit-queue/commit_queue.py	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
	M	commit-queue/verification/tree_status.py	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm https://codereview.chromium.org/59693004/diff/1/commit-queue/commit_queue.py File commit-queue/commit_queue.py (right): https://codereview.chromium.org/59693004/diff/1/commit-queue/commit_queue.py#newcode152 commit-queue/commit_queue.py:152: socket.setdefaulttimeout(60.0) I'd recommend 65 or 70 just in ...

7 years, 1 month ago (2013-11-06 00:48:27 UTC) #2

Paweł Hajdan Jr.

https://chromiumcodereview.appspot.com/59693004/diff/1/commit-queue/commit_queue.py File commit-queue/commit_queue.py (right): https://chromiumcodereview.appspot.com/59693004/diff/1/commit-queue/commit_queue.py#newcode152 commit-queue/commit_queue.py:152: socket.setdefaulttimeout(60.0) On 2013/11/06 00:48:27, M-A Ruel wrote: > I'd ...

7 years, 1 month ago (2013-11-06 01:00:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/59693004/50001

7 years, 1 month ago (2013-11-06 01:02:04 UTC) #4

Message was sent while issue was closed.

Change committed as 233167

Expand Messages | Collapse Messages

Issue 59693004: CQ: add a timeout for socket operations (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages