Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2735)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipe_modules/chromium_android/config.py

Issue 59233015: Make gyp target_arch setting native to chromium/config.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/chromium_android/chromium_config.py ('K') | « scripts/slave/recipe_modules/chromium_android/chromium_config.py ('k') | scripts/slave/recipe_modules/chromium_android/config.expected/repo-internal-from-url-bob_dot_org-internal.json » ('j') | scripts/slave/recipe_modules/gclient/config.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/config.py
diff --git a/scripts/slave/recipe_modules/chromium_android/config.py b/scripts/slave/recipe_modules/chromium_android/config.py
index 23f461a74f519b2052beda221318586105de4892..e3e470c56fad2589a4ff6a79c3d6cb59d63717ee 100644
--- a/scripts/slave/recipe_modules/chromium_android/config.py
+++ b/scripts/slave/recipe_modules/chromium_android/config.py
@@ -11,7 +11,6 @@ def BaseConfig(INTERNAL, REPO_NAME, REPO_URL, **_kwargs):
INTERNAL = Static(INTERNAL),
REPO_NAME = Static(REPO_NAME),
REPO_URL = Static(REPO_URL),
- target_arch = Single(basestring, required=False, empty_val=''),
extra_env = Dict(value_type=(basestring,int,Path)),
run_findbugs = Single(bool, required=False, empty_val=False),
run_lint = Single(bool, required=False, empty_val=False),
@@ -65,7 +64,7 @@ def component_builder(c):
@config_ctx()
def x86_base(c):
- c.target_arch = 'x86'
+ pass
@config_ctx(includes=['x86_base'])
def x86_builder(c):
« scripts/slave/recipe_modules/chromium_android/chromium_config.py ('K') | « scripts/slave/recipe_modules/chromium_android/chromium_config.py ('k') | scripts/slave/recipe_modules/chromium_android/config.expected/repo-internal-from-url-bob_dot_org-internal.json » ('j') | scripts/slave/recipe_modules/gclient/config.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698