scripts/slave/recipe_modules/gclient/config.py - Issue 59233015: Make gyp target_arch setting native to chromium/config.py

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/gclient/config.py

Issue 59233015: Make gyp target_arch setting native to chromium/config.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« scripts/slave/recipe_modules/chromium_android/chromium_config.py ('K') | « scripts/slave/recipe_modules/chromium_android/config.expected/repo-src-from-url-mike_dot_org-internal.json ('k') | scripts/slave/recipe_modules/gclient/config.expected/using_mirror-False-git_mode-False-cache_dir-False.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2013 The Chromium Authors. All rights reserved.	1 # Copyright 2013 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import types	5 import types

6	6

7 from slave.recipe_config import config_item_context, ConfigGroup, BadConf	7 from slave.recipe_config import config_item_context, ConfigGroup, BadConf

8 from slave.recipe_config import ConfigList, Dict, Single, Static, Set, List	8 from slave.recipe_config import ConfigList, Dict, Single, Static, Set, List

9	9

10 def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None, **_kwargs):	10 def BaseConfig(USE_MIRROR=True, GIT_MODE=False, CACHE_DIR=None, **_kwargs):

(...skipping 223 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
234 'supplement.DEPS')	234 'supplement.DEPS')

235	235

236 @config_ctx(config_vars={'GIT_MODE': True})	236 @config_ctx(config_vars={'GIT_MODE': True})

237 def tools_build(c):	237 def tools_build(c):

238 if not c.GIT_MODE:	238 if not c.GIT_MODE:

239 raise BadConf('tools_build only supports git')	239 raise BadConf('tools_build only supports git')

240 s = c.solutions.add()	240 s = c.solutions.add()

241 s.name = 'build'	241 s.name = 'build'

242 s.url = ChromiumGitURL(c, 'chromium', 'tools', 'build.git')	242 s.url = ChromiumGitURL(c, 'chromium', 'tools', 'build.git')

243	243

244	244 @config_ctx(includes=['chromium'])

	245 def libvpx(c):

	246 # TODO(iannucci): Youch! This path is a bit crazy.
	navabi 2013/11/08 19:01:15 What is this about? Can you also mention what th What is this about? Can you also mention what this is doing in the description of the CL, since it seems it does not have to do with moving target arch into the chromium config. iannucci 2013/11/08 19:49:57 This is an accident. I didn't mean to include it i This is an accident. I didn't mean to include it in this cl. Good catch.
	247 path = 'src/third_party/libvpx/source2/libvpx'

	248 url = 'https://chromium.googlesource.com/webm/libvpx.git'

	249 c.solutions[0].custom_deps[path] = url

OLD	NEW