Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: mojo/public/cpp/utility/lib/run_loop.cc

Issue 588593002: mojo: Allow basic RunLoop to be quit from a posted task. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Follow review Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/utility/run_loop.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/utility/lib/run_loop.cc
diff --git a/mojo/public/cpp/utility/lib/run_loop.cc b/mojo/public/cpp/utility/lib/run_loop.cc
index b06880dc9d6e0a1dbd02aaeb1cb105a9a39bad54..bcbc623a83c81040ebdace9145126d75774f7cd0 100644
--- a/mojo/public/cpp/utility/lib/run_loop.cc
+++ b/mojo/public/cpp/utility/lib/run_loop.cc
@@ -93,37 +93,40 @@ bool RunLoop::HasHandler(const Handle& handle) const {
}
void RunLoop::Run() {
- assert(current() == this);
- RunState* old_state = run_state_;
- RunState run_state;
- run_state_ = &run_state;
- while (!run_state.should_quit) {
- DoDelayedWork();
- Wait(false);
- }
- run_state_ = old_state;
+ RunInternal(UNTIL_EMPTY);
}
void RunLoop::RunUntilIdle() {
+ RunInternal(UNTIL_IDLE);
+}
+
+void RunLoop::RunInternal(RunMode run_mode) {
assert(current() == this);
RunState* old_state = run_state_;
RunState run_state;
run_state_ = &run_state;
- while (!run_state.should_quit) {
- DoDelayedWork();
- if (!Wait(true) && delayed_tasks_.empty())
+ for (;;) {
+ bool did_work = DoDelayedWork();
+ if (run_state.should_quit)
+ break;
+ did_work |= Wait(run_mode == UNTIL_IDLE);
+ if (run_state.should_quit)
+ break;
+ if (!did_work && run_mode == UNTIL_IDLE)
break;
}
run_state_ = old_state;
}
-void RunLoop::DoDelayedWork() {
+bool RunLoop::DoDelayedWork() {
MojoTimeTicks now = GetTimeTicksNow();
if (!delayed_tasks_.empty() && delayed_tasks_.top().run_time <= now) {
PendingTask task = delayed_tasks_.top();
delayed_tasks_.pop();
task.task.Run();
+ return true;
}
+ return false;
}
void RunLoop::Quit() {
« no previous file with comments | « no previous file | mojo/public/cpp/utility/run_loop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698