Issue 58853013: Refactor PermissionsData to pull out the check for scripting the webstore.

Issue 58853013: Refactor PermissionsData to pull out the check for scripting the webstore. (Closed)

Created:
7 years, 1 month ago by Yoyo Zhou

Modified:
7 years, 1 month ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, miket_OOO

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor PermissionsData to pull out the check for scripting the webstore. Move that to ExtensionsClient::IsScriptableURL. BUG=298586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234736

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -14 lines)			Patch
M	chrome/common/extensions/chrome_extensions_client.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/chrome_extensions_client.cc	View		2 chunks	+23 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/permissions_data.cc	View		4 chunks	+2 lines, -13 lines	0 comments	Download
M	extensions/common/extensions_client.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

This seems like a cleaner solution than the previous https://chromiumcodereview.appspot.com/65163003/

7 years, 1 month ago (2013-11-11 23:30:10 UTC) #1

Daniel Erat

lgtm https://chromiumcodereview.appspot.com/58853013/diff/1/extensions/common/extensions_client.h File extensions/common/extensions_client.h (right): https://chromiumcodereview.appspot.com/58853013/diff/1/extensions/common/extensions_client.h#newcode68 extensions/common/extensions_client.h:68: // Returns false if contents scripts are forbidden ...

7 years, 1 month ago (2013-11-11 23:39:27 UTC) #2

Yoyo Zhou

https://chromiumcodereview.appspot.com/58853013/diff/1/extensions/common/extensions_client.h File extensions/common/extensions_client.h (right): https://chromiumcodereview.appspot.com/58853013/diff/1/extensions/common/extensions_client.h#newcode68 extensions/common/extensions_client.h:68: // Returns false if contents scripts are forbidden from ...

7 years, 1 month ago (2013-11-11 23:56:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/58853013/50001

7 years, 1 month ago (2013-11-12 00:04:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/58853013/50001

7 years, 1 month ago (2013-11-12 23:32:49 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 1 month ago (2013-11-13 01:40:29 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/58853013/50001

7 years, 1 month ago (2013-11-13 02:23:13 UTC) #7

Message was sent while issue was closed.

Change committed as 234736

Expand Messages | Collapse Messages