Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java

Issue 586143002: Initial implementation of Cronet Async API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Helen's comments, add CronetUrlRequestContextTest. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
diff --git a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
index a0a537d041643255caee33870e96997921be1baa..5933f3a909078d88b40ab946a485c3f93ea74c36 100644
--- a/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
+++ b/components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java
@@ -22,7 +22,8 @@ public interface UrlRequestListener {
* @param info Response information.
* @param newLocation Location where request is redirected.
*/
- public void onRedirect(UrlRequest request, ResponseInfo info,
+ public void onRedirect(UrlRequest request,
+ ResponseInfo info,
URL newLocation);
/**
@@ -41,16 +42,20 @@ public interface UrlRequestListener {
* Cancelling the request also invalidates the buffer.
*
* @param request Request that received data.
+ * @param info Response information.
* @param byteBuffer Received data.
*/
- public void onDataReceived(UrlRequest request, ByteBuffer byteBuffer);
+ public void onDataReceived(UrlRequest request,
+ ResponseInfo info,
+ ByteBuffer byteBuffer);
/**
* Called when request is complete, no callbacks will be called afterwards.
*
* @param request Request that is complete.
+ * @param info Response information.
*/
- public void onComplete(UrlRequest request);
+ public void onComplete(UrlRequest request, ExtendedResponseInfo info);
/**
* Can be called at any point between start() and onComplete(). Once
@@ -58,8 +63,10 @@ public interface UrlRequestListener {
* provides information about error.
*
* @param request Request that received an error.
+ * @param info Response information.
* @param error information about error.
*/
public void onError(UrlRequest request,
+ ResponseInfo info,
UrlRequestException error);
}

Powered by Google App Engine
This is Rietveld 408576698