content/browser/frame_host/render_widget_host_view_guest.cc - Issue 584713002: Browser Plugin: Remove dependency on NPAPI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 584713002: Browser Plugin: Remove dependency on NPAPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_content_window

Patch Set: Even more cleanup! Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/common/browser_plugin/browser_plugin_constants.h » ('j') | extensions/renderer/resources/web_view.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_guest.cc

diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc

index ba5453609c5dc87a88270e3fc959c6626fddb593..60eda40763da77ff07662f096fe97437a8e0bd50 100644

--- a/content/browser/frame_host/render_widget_host_view_guest.cc

+++ b/content/browser/frame_host/render_widget_host_view_guest.cc

@@ -377,7 +377,15 @@ void RenderWidgetHostViewGuest::CopyFromCompositingSurface(

}

void RenderWidgetHostViewGuest::SetBackgroundOpaque(bool opaque) {

- platform_view_->SetBackgroundOpaque(opaque);

+ // Content embedders can toggle opaque backgrounds through this API.

+ // We plumb the value here so that BrowserPlugin updates its compositing

+ // state in response to this change. We also want to preserve this flag

+ // after recovering from a crash so we let BrowserPluginGuest store it.

+ if (!guest_)

+ return;

+ RenderWidgetHostViewBase::SetBackgroundOpaque(opaque);

+ host_->SetBackgroundOpaque(opaque);

+ guest_->SetContentsOpaque(opaque);

}

bool RenderWidgetHostViewGuest::LockMouse() {