chrome/browser/android/chrome_jni_registrar.cc - Issue 583373002: Break apart the TabModelBase's JNI calls into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 583373002: Break apart the TabModelBase's JNI calls into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Breaking apart the bridge Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelJniBridge.java ('k') | chrome/browser/ui/android/tab_model/tab_model_base.h » ('j') | chrome/browser/ui/android/tab_model/tab_model_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_jni_registrar.cc

diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc

index b00c16f6c0907fde7161ce8bb33fba4f07fa2ff4..2426137de01c3762efc07a4ae2ac0edd333c8b72 100644

--- a/chrome/browser/android/chrome_jni_registrar.cc

+++ b/chrome/browser/android/chrome_jni_registrar.cc

@@ -71,6 +71,7 @@

#include "chrome/browser/ui/android/omnibox/omnibox_view_util.h"

#include "chrome/browser/ui/android/ssl_client_certificate_request.h"

#include "chrome/browser/ui/android/tab_model/tab_model_base.h"

+#include "chrome/browser/ui/android/tab_model/tab_model_jni_bridge.h"

#include "chrome/browser/ui/android/toolbar/toolbar_model_android.h"

#include "chrome/browser/ui/android/website_settings_popup_android.h"

#include "components/bookmarks/common/android/component_jni_registrar.h"

@@ -181,6 +182,7 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {

{ "StartupMetricUtils", RegisterStartupMetricUtils },

{ "TabAndroid", TabAndroid::RegisterTabAndroid },

{ "TabModelBase", RegisterTabModelBase},

+ { "TabModelJniBridge", TabModelJniBridge::Register},

{ "TemplateUrlServiceAndroid", TemplateUrlServiceAndroid::Register },

{ "ToolbarModelAndroid", ToolbarModelAndroid::RegisterToolbarModelAndroid },

{ "TranslateInfoBarDelegate", RegisterTranslateInfoBarDelegate },