chrome/browser/ui/android/tab_model/tab_model_base.h - Issue 583373002: Break apart the TabModelBase's JNI calls into its own class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/tab_model/tab_model_base.h

Issue 583373002: Break apart the TabModelBase's JNI calls into its own class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelBase.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/tab_model/tab_model_base.h

diff --git a/chrome/browser/ui/android/tab_model/tab_model_base.h b/chrome/browser/ui/android/tab_model/tab_model_base.h

index 60b4c1e935d6284288a8ab215c346569923b83fc..9fa8fd9a2e2de7fcebbb90720922e011621ba734 100644

--- a/chrome/browser/ui/android/tab_model/tab_model_base.h

+++ b/chrome/browser/ui/android/tab_model/tab_model_base.h

@@ -28,6 +28,7 @@ class TabModelBase : public TabModel {

public:

TabModelBase(JNIEnv* env, jobject obj, Profile* profile);

void Destroy(JNIEnv* env, jobject obj);

+ virtual ~TabModelBase();

// Called by JNI

base::android::ScopedJavaLocalRef<jobject> GetProfileAndroid(JNIEnv* env,

@@ -55,9 +56,7 @@ class TabModelBase : public TabModel {

// loaded from storage.

void BroadcastSessionRestoreComplete(JNIEnv* env, jobject obj);

- private:

- virtual ~TabModelBase();

+ protected:

JavaObjectWeakGlobalRef java_object_;

};