Add script to update Closure Compiler version and chrome_extensions.js

Add script to update Closure Compiler version and chrome_extensions.js

R=dbeam@chromium.org
BUG=393873
TEST=./third_party/closure_compiler/bump_compiler_version

Committed: https://crrev.com/641efff1566c569f02d395f872d4c4f5c965d217
Cr-Commit-Position: refs/heads/master@{#295643}

[Dan Beam, 2014-09-18 21:26:08]

remove compiler.jar from CL, add note to
third_party/closure_compiler/README.chromium

https://chromiumcodereview.appspot.com/582193002/diff/1/third_party/closure_c...
File third_party/closure_compiler/bump_compiler_version (right):

https://chromiumcodereview.appspot.com/582193002/diff/1/third_party/closure_c...
third_party/closure_compiler/bump_compiler_version:15: readonly SCRIPT_DIR="$(
cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

https://chromiumcodereview.appspot.com/582193002/diff/1/third_party/closure_c...
third_party/closure_compiler/bump_compiler_version:32: echo "Failed to build
jar, copy nothing"
we need to exit with non-zero exit status somehow here

[Dan Beam, 2014-09-18 21:26:30]

oh yeah, and add a .sh file extension to bump_compiler_version

[Vitaly Pavlenko, 2014-09-18 21:49:44]

https://chromiumcodereview.appspot.com/582193002/diff/1/third_party/closure_c...
File third_party/closure_compiler/bump_compiler_version (right):

https://chromiumcodereview.appspot.com/582193002/diff/1/third_party/closure_c...
third_party/closure_compiler/bump_compiler_version:15: readonly SCRIPT_DIR="$(
cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
On 2014/09/18 21:26:07, Dan Beam wrote:
> readonly SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"

Done.

https://chromiumcodereview.appspot.com/582193002/diff/1/third_party/closure_c...
third_party/closure_compiler/bump_compiler_version:32: echo "Failed to build
jar, copy nothing"
On 2014/09/18 21:26:08, Dan Beam wrote:
> we need to exit with non-zero exit status somehow here

Done.

[Dan Beam, 2014-09-18 21:52:53]

On 2014/09/18 21:26:30, Dan Beam wrote:
> oh yeah, and add a .sh file extension to bump_compiler_version

oh, didn't know about
https://google-styleguide.googlecode.com/svn/trunk/shell.xml#File_Extensions,
you can ignore this :)

[Dan Beam, 2014-09-18 21:58:11]

On 2014/09/18 21:26:08, Dan Beam wrote:
> remove compiler.jar from CL, add note to
> third_party/closure_compiler/README.chromium

still haven't done this

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
File third_party/closure_compiler/bump_compiler_version (right):

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:13: # c) Commit.
^ I don't think L9-13 are particularly useful

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:21: 
add

  trap cleanup SIGINT SIGHUP SIGTERM

to make cleanup work even if ctrl+c is pressed in the middle

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:30: if [[ "$?" -eq 0 ]]; then
nit: $? will never be empty here, so you don't *need* "$?"

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:30: if [[ "$?" -eq 0 ]]; then
nit:

if [[ $? -ne 0 ]]; then
  echo "Failed to build jar, copy nothing" >&2
  cleanup
  exit 1
fi

echo "Copying compiler.jar and chrome_extensions.js"
...

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:37: echo "Failed to build
jar, copy nothing"
probably ought to output this to stderr, e.g.

  echo >&2 "blah"

OR

  echo "blah" >&2

[Vitaly Pavlenko, 2014-09-18 23:16:11]

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
File third_party/closure_compiler/bump_compiler_version (right):

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:13: # c) Commit.
On 2014/09/18 21:58:11, Dan Beam wrote:
> ^ I don't think L9-13 are particularly useful

Done.

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:21: 
On 2014/09/18 21:58:11, Dan Beam wrote:
> add
> 
>   trap cleanup SIGINT SIGHUP SIGTERM
> 
> to make cleanup work even if ctrl+c is pressed in the middle

Done. However, I can't reproduce the use case. Eg. if I hold Ctrl+C during git
clone, git clone aborts, but the script itself continues to work and invokes
cleanup from "else" branch.

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:30: if [[ "$?" -eq 0 ]]; then
On 2014/09/18 21:58:11, Dan Beam wrote:
> nit:
> 
> if [[ $? -ne 0 ]]; then
>   echo "Failed to build jar, copy nothing" >&2
>   cleanup
>   exit 1
> fi
> 
> echo "Copying compiler.jar and chrome_extensions.js"
> ...

Done.

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:30: if [[ "$?" -eq 0 ]]; then
On 2014/09/18 21:58:11, Dan Beam wrote:
> nit: $? will never be empty here, so you don't *need* "$?"

As I understand the style guide, I should apply the rule "quote your variables"
here.

https://google-styleguide.googlecode.com/svn/trunk/shell.xml?showone=Variable...

https://chromiumcodereview.appspot.com/582193002/diff/40001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:37: echo "Failed to build
jar, copy nothing"
On 2014/09/18 21:58:11, Dan Beam wrote:
> probably ought to output this to stderr, e.g.
> 
>   echo >&2 "blah"
> 
> OR
> 
>   echo "blah" >&2

Ought to:
https://google-styleguide.googlecode.com/svn/trunk/shell.xml?showone=STDOUT_v...

Done.

[Dan Beam, 2014-09-18 23:21:15]

On 2014/09/18 21:26:08, Dan Beam wrote:
> remove compiler.jar from CL, add note to
> third_party/closure_compiler/README.chromium

still still haven't done this

[Vitaly Pavlenko, 2014-09-19 00:56:12]

On 2014/09/18 23:21:15, Dan Beam wrote:
> On 2014/09/18 21:26:08, Dan Beam wrote:
> > remove compiler.jar from CL, add note to
> > third_party/closure_compiler/README.chromium
> 
> still still haven't done this

Done now.

[Dan Beam, 2014-09-19 01:02:39]

lgtm

https://chromiumcodereview.appspot.com/582193002/diff/60001/third_party/closu...
File third_party/closure_compiler/bump_compiler_version (right):

https://chromiumcodereview.appspot.com/582193002/diff/60001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:27: echo "Failed to build
jar, copy nothing" >&2
copy nothing => copying nothing OR nothing to copy

[Vitaly Pavlenko, 2014-09-19 01:32:22]

https://chromiumcodereview.appspot.com/582193002/diff/60001/third_party/closu...
File third_party/closure_compiler/bump_compiler_version (right):

https://chromiumcodereview.appspot.com/582193002/diff/60001/third_party/closu...
third_party/closure_compiler/bump_compiler_version:27: echo "Failed to build
jar, copy nothing" >&2
On 2014/09/19 01:02:39, Dan Beam wrote:
> copy nothing => copying nothing OR nothing to copy

Done.

[Vitaly Pavlenko, 2014-09-19 01:32:26]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-19 01:33:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/582193002/100001

[commit-bot: I haz the power, 2014-09-19 02:30:27]

Committed patchset #6 (id:100001) as ffada7e8a39b1f04154264d2b52245ebf7da99c2

[commit-bot: I haz the power, 2014-09-19 02:31:26]

Patchset 6 (id:??) landed as
https://crrev.com/641efff1566c569f02d395f872d4c4f5c965d217
Cr-Commit-Position: refs/heads/master@{#295643}