Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1350)

Unified Diff: content/browser/frame_host/navigator_impl.h

Issue 577963002: Add time-to-network histogram considering browser side navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: histogram.xml Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.h
diff --git a/content/browser/frame_host/navigator_impl.h b/content/browser/frame_host/navigator_impl.h
index 42262935862a757b5bc3cb0b6bef3ae989c75d8d..f79330e269d05012570313cc9af5eee170b345c2 100644
--- a/content/browser/frame_host/navigator_impl.h
+++ b/content/browser/frame_host/navigator_impl.h
@@ -6,6 +6,7 @@
#define CONTENT_BROWSER_FRAME_HOST_NAVIGATOR_IMPL_H_
#include "base/memory/ref_counted.h"
+#include "base/time/time.h"
#include "content/browser/frame_host/navigation_controller_impl.h"
#include "content/browser/frame_host/navigator.h"
#include "content/common/content_export.h"
clamy 2014/09/19 14:56:03 You need to include url/gurl.h since you now have
carlosk 2014/09/23 17:02:57 Done.
@@ -78,6 +79,9 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
RenderFrameHostImpl* render_frame_host,
const NavigationBeforeCommitInfo& info) OVERRIDE;
+ virtual void LogResourceRequestTime(base::TimeTicks timestamp, GURL url)
+ OVERRIDE;
+
private:
virtual ~NavigatorImpl() {}
@@ -104,6 +108,13 @@ class CONTENT_EXPORT NavigatorImpl : public Navigator {
// events. Can be NULL in tests.
NavigatorDelegate* delegate_;
+ // The time the latest navigation request started for histogram building
clamy 2014/09/19 14:56:03 nit: How about: The time the latest navigation req
carlosk 2014/09/23 17:02:57 Done but I mentioned the group name instead as the
+ // purposes.
+ base::TimeTicks navigation_start_time_;
+ // The URL of a started navigation to double check later if reported times
+ // match the currently active navigation.
+ GURL navigation_start_url_;
+
DISALLOW_COPY_AND_ASSIGN(NavigatorImpl);
};

Powered by Google App Engine
This is Rietveld 408576698