Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: ui/webui/resources/js/event_tracker.js

Issue 575333002: Compile print_preview, part 2: reduce down to 260 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview
Patch Set: revert movement of enums: now handle in compiler pass Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/cr/event_target.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/event_tracker.js
diff --git a/ui/webui/resources/js/event_tracker.js b/ui/webui/resources/js/event_tracker.js
index d28c5b7ff55130fb542616680ec41a5370762557..807d9247113abb793a494c458ee6120c561909f6 100644
--- a/ui/webui/resources/js/event_tracker.js
+++ b/ui/webui/resources/js/event_tracker.js
@@ -15,7 +15,7 @@
* The type of the internal tracking entry. TODO(dbeam): move this back to
* EventTracker.Entry when https://github.com/google/closure-compiler/issues/544
* is fixed.
- * @typedef {{node: !Node,
+ * @typedef {{target: !EventTarget,
* eventType: string,
* listener: Function,
* capture: boolean}}
@@ -39,32 +39,32 @@ function EventTracker() {
EventTracker.prototype = {
/**
- * Add an event listener - replacement for Node.addEventListener.
- * @param {!Node} node The DOM node to add a listener to.
+ * Add an event listener - replacement for EventTarget.addEventListener.
+ * @param {!EventTarget} target The DOM target to add a listener to.
* @param {string} eventType The type of event to subscribe to.
* @param {EventListener|Function} listener The listener to add.
* @param {boolean=} opt_capture Whether to invoke during the capture phase.
*/
- add: function(node, eventType, listener, opt_capture) {
+ add: function(target, eventType, listener, opt_capture) {
var capture = !!opt_capture;
var h = {
- node: node,
+ target: target,
eventType: eventType,
listener: listener,
capture: capture,
};
this.listeners_.push(h);
- node.addEventListener(eventType, listener, capture);
+ target.addEventListener(eventType, listener, capture);
},
/**
* Remove any specified event listeners added with this EventTracker.
- * @param {!Node} node The DOM node to remove a listener from.
+ * @param {!EventTarget} target The DOM target to remove a listener from.
* @param {?string} eventType The type of event to remove.
*/
- remove: function(node, eventType) {
+ remove: function(target, eventType) {
this.listeners_ = this.listeners_.filter(function(h) {
- if (h.node == node && (!eventType || (h.eventType == eventType))) {
+ if (h.target == target && (!eventType || (h.eventType == eventType))) {
EventTracker.removeEventListener_(h);
return false;
}
@@ -88,5 +88,5 @@ EventTracker.prototype = {
* @private
*/
EventTracker.removeEventListener_ = function(h) {
- h.node.removeEventListener(h.eventType, h.listener, h.capture);
+ h.target.removeEventListener(h.eventType, h.listener, h.capture);
};
« no previous file with comments | « ui/webui/resources/js/cr/event_target.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698