chrome/browser/resources/print_preview/common/search_box.js - Issue 575333002: Compile print_preview, part 2: reduce down to 260 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/common/search_box.js

Issue 575333002: Compile print_preview, part 2: reduce down to 260 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview

Patch Set: revert movement of enums: now handle in compiler pass Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/print_preview/common/search_box.js

diff --git a/chrome/browser/resources/print_preview/common/search_box.js b/chrome/browser/resources/print_preview/common/search_box.js

index 723174b74982fea97aa2c0643ae543c85b28d9a3..f9efd30264dc6dbeb51b0cfccd51eedc69db3de7 100644

--- a/chrome/browser/resources/print_preview/common/search_box.js

+++ b/chrome/browser/resources/print_preview/common/search_box.js

@@ -51,7 +51,7 @@ cr.define('print_preview', function() {

SearchBox.prototype = {

__proto__: print_preview.Component.prototype,

- /** @param {string} query New query to set the search box's query to. */

+ /** @param {?string} query New query to set the search box's query to. */

setQuery: function(query) {

query = query || '';

this.input_.value = query.trim();

@@ -73,7 +73,8 @@ cr.define('print_preview', function() {

/** @override */

enterDocument: function() {

print_preview.Component.prototype.enterDocument.call(this);

- this.tracker.add(this.input_, 'input', this.onInputInput_.bind(this));

+ this.tracker.add(assert(this.input_), 'input',

+ this.onInputInput_.bind(this));

/** @override */

« no previous file with comments | « no previous file | chrome/browser/resources/print_preview/common/search_bubble.js » ('j') | no next file with comments »