Compile print_preview, part 2: reduce down to 260 errors

chrome/browser/resources/print_preview/print_preview_utils.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @param {string} toTest The string to be tested.
  * @return {boolean} True if |toTest| contains only digits. Leading and trailing
  *     whitespace is allowed.
  */
 function isInteger(toTest) {
@@ skipping 38 matching lines @@
     if (array1[i].from != array2[i].from ||
         array1[i].to != array2[i].to) {
     return false;
   }
   return true;
 }
 
 /**
  * Removes duplicate elements from |inArray| and returns a new array.
  * |inArray| is not affected. It assumes that |inArray| is already sorted.
- * @param {Array.<number>} inArray The array to be processed.
- * @return {Array.<number>} The array after processing.
+ * @param {!Array.<number>} inArray The array to be processed.
+ * @return {!Array.<number>} The array after processing.
  */
 function removeDuplicates(inArray) {
   var out = [];
 
   if (inArray.length == 0)
     return out;
 
   out.push(inArray[0]);
   for (var i = 1; i < inArray.length; ++i)
     if (inArray[i] != inArray[i - 1])
@@ skipping 15 matching lines @@
  * Wildcard the second number must be larger then the first number. If it's
  * missed then |totalPageCount| is used as the second number.
  * Example: "1-4, 9, 3-6, 10, 11" is valid, assuming |totalPageCount| >= 11.
  * Example: "1-4, -6" is valid, assuming |totalPageCount| >= 6.
  * Example: "2-" is valid, assuming |totalPageCount| >= 2, means from 2 to the
  *          end.
  * Example: "4-2, 11, -6" is invalid.
  * Example: "-" is valid, assuming |totalPageCount| >= 1.
  * Example: "1-4dsf, 11" is invalid regardless of |totalPageCount|.
  * @param {string} pageRangeText The text to be checked.
- * @param {number} totalPageCount The total number of pages.
+ * @param {?number} totalPageCount The total number of pages.

[Aleksey Shlyapnikov, 2014/09/19 18:54:42]

Maybe {number=} makes more sense here?

[Vitaly Pavlenko, 2014/09/19 20:33:09]

You are right. Done.

  * @return {Array.<{from: number, to: number}>} An array of page range objects.
  */
 function pageRangeTextToPageRanges(pageRangeText, totalPageCount) {
   if (pageRangeText == '') {
     return [];
   }
 
   var MAX_PAGE_NUMBER = 1000000000;
   totalPageCount = totalPageCount ? totalPageCount : MAX_PAGE_NUMBER;
 
@@ skipping 47 matching lines @@
     }
   }
   if (pageList.length == 0) {
     for (var j = 1; j <= totalPageCount; ++j)
       pageList.push(j);
   }
   return pageList;
 }
 
 /**
- * @param {Array.<number>} pageList The list to be processed.
- * @return {Array.<number>} The contents of |pageList| in ascending order and
+ * @param {!Array.<number>} pageList The list to be processed.
+ * @return {!Array.<number>} The contents of |pageList| in ascending order and
  *     without any duplicates. |pageList| is not affected.
  */
 function pageListToPageSet(pageList) {
   var pageSet = [];
   if (pageList.length == 0)
     return pageSet;
   pageSet = pageList.slice(0);
   pageSet.sort(function(a, b) {
     return (/** @type {number} */ a) - (/** @type {number} */ b);
   });
@@ skipping 19 matching lines @@
 }
 
 /**
  * @param {!Array} array Array to check for item.
  * @param {*} item Item to look for in array.
  * @return {boolean} Whether the item is in the array.
  */
 function arrayContains(array, item) {
   return array.indexOf(item) != -1;
 }