Compile print_preview, part 2: reduce down to 260 errors

chrome/browser/resources/print_preview/data/destination_store.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * A data store that stores destinations and dispatches events when the data
    * store changes.
@@ skipping 37 matching lines @@
 
     /**
      * Internal backing store for the data store.
      * @type {!Array.<!print_preview.Destination>}
      * @private
      */
     this.destinations_ = [];
 
     /**
      * Cache used for constant lookup of destinations by origin and id.
-     * @type {object.<string, !print_preview.Destination>}
+     * @type {Object.<string, !print_preview.Destination>}
      * @private
      */
     this.destinationMap_ = {};
 
     /**
      * Currently selected destination.
      * @type {print_preview.Destination}
      * @private
      */
     this.selectedDestination_ = null;
@@ skipping 16 matching lines @@
     /**
      * Whether PDF printer is enabled. It's disabled, for example, in App Kiosk
      * mode.
      * @type {boolean}
      * @private
      */
     this.pdfPrinterEnabled_ = false;
 
     /**
      * Used to fetch cloud-based print destinations.
-     * @type {print_preview.CloudPrintInterface}
+     * @type {cloudprint.CloudPrintInterface}
      * @private
      */
     this.cloudPrintInterface_ = null;
 
     /**
      * Maps user account to the list of origins for which destinations are
      * already loaded.
      * @type {!Object.<string, Array.<print_preview.Destination.Origin>>}
      * @private
      */
@@ skipping 158 matching lines @@
      */
     get isLocalDestinationSearchInProgress() {
       return this.isLocalDestinationSearchInProgress_ ||
         this.isPrivetDestinationSearchInProgress_;
     },
 
     /**
      * @return {boolean} Whether a search for cloud destinations is in progress.
      */
     get isCloudDestinationSearchInProgress() {
-      return this.cloudPrintInterface_ &&
+      return !!this.cloudPrintInterface_ &&

[Lei Zhang, 2014/09/19 00:54:20]

Is there a preference between !!foo vs. foo != null ?

[Vitaly Pavlenko, 2014/09/19 00:57:59]

I just insert the general !! cast in all cases. I don't know if it's a good idea
to do so here. Aleksey, what do you think?

[Aleksey Shlyapnikov, 2014/09/19 18:54:42]

This is a pointer check, why would we convert it to boolean? Same semantics,
more code. Let's leave it as it was.

[Vitaly Pavlenko, 2014/09/19 20:33:09]

Otherwise Closure Compiler whines that we possibly return non-boolean from
function that is supposed to return boolean type.

              this.cloudPrintInterface_.isCloudDestinationSearchInProgress;
     },
 
     /**
      * Initializes the destination store. Sets the initially selected
      * destination. If any inserted destinations match this ID, that destination
      * will be automatically selected. This method must be called after the
      * print_preview.AppState has been initialized.
      * @param {boolean} isInAppKioskMode Whether the print preview is in App
      *     Kiosk mode.
@@ skipping 51 matching lines @@
             this,
             DestinationStore.EventType.CACHED_SELECTED_DESTINATION_INFO_READY);
         } else {
           this.selectDefaultDestination_();
         }
       }
     },
 
     /**
      * Sets the destination store's Google Cloud Print interface.
-     * @param {!print_preview.CloudPrintInterface} cloudPrintInterface Interface
+     * @param {!cloudprint.CloudPrintInterface} cloudPrintInterface Interface
      *     to set.
      */
     setCloudPrintInterface: function(cloudPrintInterface) {
       this.cloudPrintInterface_ = cloudPrintInterface;
       this.tracker_.add(
           this.cloudPrintInterface_,
           cloudprint.CloudPrintInterface.EventType.SEARCH_DONE,
           this.onCloudPrintSearchDone_.bind(this));
       this.tracker_.add(
           this.cloudPrintInterface_,
@@ skipping 16 matching lines @@
     hasOnlyDefaultCloudDestinations: function() {
       // TODO: Move the logic to print_preview.
       return this.destinations_.every(function(dest) {
         return dest.isLocal ||
             dest.id == print_preview.Destination.GooglePromotedId.DOCS ||
             dest.id == print_preview.Destination.GooglePromotedId.FEDEX;
       });
     },
 
     /**
-     * @param {!print_preview.Destination} destination Destination to select.
+     * @param {print_preview.Destination} destination Destination to select.
      */
     selectDestination: function(destination) {
       this.isInAutoSelectMode_ = false;
       // When auto select expires, DESTINATION_SELECT event has to be dispatched
       // anyway (see isAutoSelectDestinationInProgress() logic).
       if (this.autoSelectTimeout_) {
         clearTimeout(this.autoSelectTimeout_);
         this.autoSelectTimeout_ = null;
       } else if (destination == this.selectedDestination_) {
         return;
@@ skipping 422 matching lines @@
      * @private
      */
     onCloudPrintPrinterDone_: function(event) {
       this.updateDestination_(event.printer);
     },
 
     /**
      * Called when the Google Cloud Print interface fails to lookup a
      * destination. Selects another destination if the failed destination was
      * the initial destination.
-     * @param {object} event Contains the ID of the destination that was failed
+     * @param {Object} event Contains the ID of the destination that was failed
      *     to be looked up.
      * @private
      */
     onCloudPrintPrinterFailed_: function(event) {
       if (this.isInAutoSelectMode_ &&
           this.sameAsPersistedDestination_(event.destinationId,
                                            event.destinationOrigin)) {
         console.error(
             'Failed to fetch last used printer caps: ' + event.destinationId);
         this.selectDefaultDestination_();
       }
     },
 
     /**
      * Called when a Privet printer is added to the local network.
-     * @param {object} event Contains information about the added printer.
+     * @param {Object} event Contains information about the added printer.
      * @private
      */
     onPrivetPrinterAdded_: function(event) {
       if (event.printer.serviceName == this.waitForRegisterDestination_ &&
           !event.printer.isUnregistered) {
         this.waitForRegisterDestination_ = null;
         this.onDestinationsReload_();
       } else {
         this.insertDestinations_(
             print_preview.PrivetDestinationParser.parse(event.printer));
       }
     },
 
     /**
      * Called when capabilities for a privet printer are set.
-     * @param {object} event Contains the capabilities and printer ID.
+     * @param {Object} event Contains the capabilities and printer ID.
      * @private
      */
     onPrivetCapabilitiesSet_: function(event) {
       var destinationId = event.printerId;
       var destinations =
           print_preview.PrivetDestinationParser.parse(event.printer);
       destinations.forEach(function(dest) {
         dest.capabilities = event.capabilities;
         this.updateDestination_(dest);
       }, this);
@@ skipping 11 matching lines @@
       this.startLoadLocalDestinations();
       this.startLoadCloudDestinations();
       this.startLoadPrivetDestinations();
     },
 
     // TODO(vitalybuka): Remove three next functions replacing Destination.id
     //    and Destination.origin by complex ID.
     /**
      * Returns key to be used with {@code destinationMap_}.
      * @param {!print_preview.Destination.Origin} origin Destination origin.
-     * @return {string} id Destination id.
-     * @return {string} account User account destination is registered for.
+     * @param {string} id Destination id.
+     * @param {string} account User account destination is registered for.
      * @private
      */
     getDestinationKey_: function(origin, id, account) {
       return origin + '/' + id + '/' + account;
     },
 
     /**
      * Returns key to be used with {@code destinationMap_}.
      * @param {!print_preview.Destination} destination Destination.
      * @private
@@ skipping 26 matching lines @@
       return id == this.appState_.selectedDestinationId &&
              origin == this.appState_.selectedDestinationOrigin;
     }
   };
 
   // Export
   return {
     DestinationStore: DestinationStore
   };
 });