Compile print_preview, part 2: reduce down to 260 errors

chrome/browser/resources/print_preview/data/app_state.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Object used to get and persist the print preview application state.
    * @constructor
@@ skipping 11 matching lines @@
     /**
      * Whether the app state has been initialized. The app state will ignore all
      * writes until it has been initialized.
      * @type {boolean}
      * @private
      */
     this.isInitialized_ = false;
   };
 
   /**
-   * Enumeration of field names for serialized app state.
-   * @enum {string}
-   */
-  AppState.Field = {
-    VERSION: 'version',
-    SELECTED_DESTINATION_ID: 'selectedDestinationId',
-    SELECTED_DESTINATION_ACCOUNT: 'selectedDestinationAccount',
-    SELECTED_DESTINATION_ORIGIN: 'selectedDestinationOrigin',
-    SELECTED_DESTINATION_CAPABILITIES: 'selectedDestinationCapabilities',
-    SELECTED_DESTINATION_NAME: 'selectedDestinationName',
-    IS_GCP_PROMO_DISMISSED: 'isGcpPromoDismissed',
-    MEDIA_SIZE: 'mediaSize',
-    MARGINS_TYPE: 'marginsType',
-    CUSTOM_MARGINS: 'customMargins',
-    IS_COLOR_ENABLED: 'isColorEnabled',
-    IS_DUPLEX_ENABLED: 'isDuplexEnabled',
-    IS_HEADER_FOOTER_ENABLED: 'isHeaderFooterEnabled',
-    IS_LANDSCAPE_ENABLED: 'isLandscapeEnabled',
-    IS_COLLATE_ENABLED: 'isCollateEnabled',
-    IS_CSS_BACKGROUND_ENABLED: 'isCssBackgroundEnabled',
-    VENDOR_OPTIONS: 'vendorOptions'
-  };
-
-  /**
    * Current version of the app state. This value helps to understand how to
    * parse earlier versions of the app state.
    * @type {number}
    * @const
    * @private
    */
   AppState.VERSION_ = 2;
 
   /**
    * Name of C++ layer function to persist app state.
@@ skipping 145 matching lines @@
     persist_: function() {
       chrome.send(AppState.NATIVE_FUNCTION_NAME_,
                   [JSON.stringify(this.state_)]);
     }
   };
 
   return {
     AppState: AppState
   };
 });
+
+/**
+ * Enumeration of field names for serialized app state.
+ * @enum {string}
+ */
+print_preview.AppState.Field = {
+  VERSION: 'version',
+  SELECTED_DESTINATION_ID: 'selectedDestinationId',
+  SELECTED_DESTINATION_ACCOUNT: 'selectedDestinationAccount',
+  SELECTED_DESTINATION_ORIGIN: 'selectedDestinationOrigin',
+  SELECTED_DESTINATION_CAPABILITIES: 'selectedDestinationCapabilities',
+  SELECTED_DESTINATION_NAME: 'selectedDestinationName',
+  IS_GCP_PROMO_DISMISSED: 'isGcpPromoDismissed',
+  MEDIA_SIZE: 'mediaSize',
+  MARGINS_TYPE: 'marginsType',
+  CUSTOM_MARGINS: 'customMargins',
+  IS_COLOR_ENABLED: 'isColorEnabled',
+  IS_DUPLEX_ENABLED: 'isDuplexEnabled',
+  IS_HEADER_FOOTER_ENABLED: 'isHeaderFooterEnabled',
+  IS_LANDSCAPE_ENABLED: 'isLandscapeEnabled',
+  IS_COLLATE_ENABLED: 'isCollateEnabled',
+  IS_CSS_BACKGROUND_ENABLED: 'isCssBackgroundEnabled',
+  VENDOR_OPTIONS: 'vendorOptions'
+};

[Aleksey Shlyapnikov, 2014/09/19 18:54:42]

What's the reason for this and other similar changes?

[Vitaly Pavlenko, 2014/09/19 20:33:09]

Right now Closure Compiler doesn't understand @typedefs and @enums if they are
placed inside function scope:
https://github.com/google/closure-compiler/issues/544

So I need to move them to a global scope to make the typechecking work.