command_buffer: infer all generated c/c++ source files to clang-format

command_buffer: infer all generated c/c++ source files to clang-format

Gather a list of generated files in build_gles2_cmd_buffer.py rather
than using a manual list.

Calls format for
gpu/command_buffer/service/gles2_cmd_decoder_unittest_extensions_autogen.h,
which was previously omitted.

Committed: https://crrev.com/c6d943365002fbe85057ad7a6281756b844d31d1
Cr-Commit-Position: refs/heads/master@{#297388}

[Kimmo Kinnunen, 2014-09-16 07:21:30]

kkinnunen@nvidia.com changed reviewers:
+ vmiura@chromium.org

[vmiura, 2014-09-19 23:04:24]

On 2014/09/16 07:21:31, Kimmo Kinnunen wrote:

lgtm

[Kimmo Kinnunen, 2014-09-29 08:23:49]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-09-29 08:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/573953002/20001

[commit-bot: I haz the power, 2014-09-29 08:31:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 08:31:43]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Kimmo Kinnunen, 2014-09-29 10:58:33]

kkinnunen@nvidia.com changed reviewers:
+ dmichael@chromium.org

[Kimmo Kinnunen, 2014-09-29 10:58:34]

dmichael, could you look at the ppapi/ changes? For some reason trunk does not
have the files formatted.

[dmichael (off chromium), 2014-09-29 15:25:23]

I think it's just a new version of the formatter. Part of the changes look good,
part looks weird to me. Either way, it's easier to just take what the formatter
gives us for these files than to worry too much about it.

ppapi lgtm

https://chromiumcodereview.appspot.com/573953002/diff/20001/ppapi/lib/gl/gles...
File ppapi/lib/gl/gles2/gles2.c (right):

https://chromiumcodereview.appspot.com/573953002/diff/20001/ppapi/lib/gl/gles...
ppapi/lib/gl/gles2/gles2.c:28: glBindAttribLocation(GLuint program, GLuint
index, const char* name) {
This is a little weird; I would've thought that it shouldn't have the 4-space
indent. clang-format probably gets confused by the GL_APIENTRY. You can file a
bug against clang-format if you want. See the bottom of this page:
https://code.google.com/p/chromium/wiki/ClangFormat

https://chromiumcodereview.appspot.com/573953002/diff/20001/ppapi/shared_impl...
File ppapi/shared_impl/ppb_opengles2_shared.cc (right):

https://chromiumcodereview.appspot.com/573953002/diff/20001/ppapi/shared_impl...
ppapi/shared_impl/ppb_opengles2_shared.cc:1611: &ActiveTexture,
This was an intentional change to the formatter, I think. See
https://code.google.com/p/chromium/issues/detail?id=360644

[Kimmo Kinnunen, 2014-09-30 07:07:22]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2014-09-30 07:07:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/573953002/20001

[commit-bot: I haz the power, 2014-09-30 08:54:56]

Committed patchset #2 (id:20001) as 2af16554a9dcb83babeaa35377ce476b37beb28c

[commit-bot: I haz the power, 2014-09-30 08:56:28]

Patchset 2 (id:??) landed as
https://crrev.com/c6d943365002fbe85057ad7a6281756b844d31d1
Cr-Commit-Position: refs/heads/master@{#297388}

[Kimmo Kinnunen, 2014-10-02 05:16:59]

dmichael wrote:
> ppapi lgtm

Thanks for the review.

>
https://chromiumcodereview.appspot.com/573953002/diff/20001/ppapi/lib/gl/gles...
> ppapi/lib/gl/gles2/gles2.c:28: glBindAttribLocation(GLuint program, GLuint
> index, const char* name) {
> This is a little weird; I would've thought that it shouldn't have the 4-space
> indent. clang-format probably gets confused by the GL_APIENTRY. You can file a
> bug against clang-format if you want.

Bug 418883: https://code.google.com/p/chromium/issues/detail?id=418883