Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4413)

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.js

Issue 570503002: Compile chrome://settings, part 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_4
Patch Set: fix asserts, rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/chromeos/internet_detail.js
diff --git a/chrome/browser/resources/options/chromeos/internet_detail.js b/chrome/browser/resources/options/chromeos/internet_detail.js
index e4235695322367803a77f60db43514cf92da1965..d907ae8473a981db2e3afce543184ff8a201a03d 100644
--- a/chrome/browser/resources/options/chromeos/internet_detail.js
+++ b/chrome/browser/resources/options/chromeos/internet_detail.js
@@ -387,11 +387,13 @@ cr.define('options.internet', function() {
* Creates an indicator event for controlled properties using
* the same dictionary format as CoreOptionsHandler::CreateValueForPref.
* @param {string} name The name for the Event.
- * @param {!{value: *, controlledBy: *, recommendedValue: *}} propData
- * Property dictionary,
+ * @param {{value: *, controlledBy: *, recommendedValue: *}} propData
+ * Property dictionary.
* @private
*/
createControlledEvent_: function(name, propData) {
+ assert('value' in propData && 'controlledBy' in propData &&
+ 'recommendedValue' in propData);
var event = new Event(name);
event.value = {
value: propData.value,
@@ -1569,11 +1571,14 @@ cr.define('options.internet', function() {
onc.getActiveValue(propName);
if (propValue == undefined)
continue;
+ propValue = assertInstanceof(propValue, Object);
stevenjb 2014/11/05 20:30:15 While I do appreciate this effort, this actually i
var event;
if (managed)
event = detailsPage.createManagedEvent_(propName, propValue);
else
- event = detailsPage.createControlledEvent_(propName, propValue);
+ event = detailsPage.createControlledEvent_(propName,
+ /** @type {{value: *, controlledBy: *, recommendedValue: *}} */(
+ propValue));
indicators[i].handlePrefChange(event);
var forElement = $(indicators[i].getAttribute('for'));
if (forElement) {

Powered by Google App Engine
This is Rietveld 408576698