Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5991)

Unified Diff: chrome/browser/resources/chromeos/user_images_grid.js

Issue 570503002: Compile chrome://settings, part 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_4
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/user_images_grid.js
diff --git a/chrome/browser/resources/chromeos/user_images_grid.js b/chrome/browser/resources/chromeos/user_images_grid.js
index ce994ca4ce9b400c985ff692575a1e9d13e54d68..e3ec67965d0ba22f8976687e6606685fc74813bd 100644
--- a/chrome/browser/resources/chromeos/user_images_grid.js
+++ b/chrome/browser/resources/chromeos/user_images_grid.js
@@ -26,9 +26,10 @@ cr.define('options', function() {
/**
* Creates a new user images grid item.
- * @param {{url: string, title: (string|undefined),
+ * @param {Object} imageInfo Object of the following structure:
+ * {url: string, title: (string|undefined),
* decorateFn: (!Function|undefined),
- * clickHandler: (!Function|undefined)}} imageInfo User image URL,
+ * clickHandler: (!Function|undefined)}. Contains user image URL,
Dan Beam 2014/09/12 03:25:19 why are you making this more loosely typed?
Vitaly Pavlenko 2014/09/12 19:16:22 I previously had issues with line 127:
* optional title, decorator callback and click handler.
* @constructor
* @extends {cr.ui.GridItem}

Powered by Google App Engine
This is Rietveld 408576698