Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: extensions/common/test_util.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/test_util.cc
diff --git a/extensions/common/test_util.cc b/extensions/common/test_util.cc
index 03b35b84801522cd6f945ee3b99549e9a9efb362..e003ea1fd13da00c78e8a3d8d43264dc8a260a7c 100644
--- a/extensions/common/test_util.cc
+++ b/extensions/common/test_util.cc
@@ -6,6 +6,7 @@
#include "base/json/json_reader.h"
#include "base/values.h"
+#include "components/crx_file/id_util.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/value_builder.h"
@@ -23,15 +24,13 @@ ExtensionBuilder& BuildExtension(ExtensionBuilder& builder) {
}
scoped_refptr<Extension> CreateEmptyExtension() {
- scoped_refptr<Extension> empty_extension(
- ExtensionBuilder()
- .SetManifest(
- DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
- .Build());
- return empty_extension;
+ return ExtensionBuilder()
+ .SetManifest(
+ DictionaryBuilder().Set("name", "Test").Set("version", "1.0"))
+ .Build();
}
-scoped_refptr<Extension> CreateExtensionWithID(const std::string& id) {
+scoped_refptr<Extension> CreateEmptyExtension(const std::string& id) {
return ExtensionBuilder()
.SetManifest(
DictionaryBuilder().Set("name", "test").Set("version", "0.1"))
« chrome/browser/extensions/api/identity/identity_apitest.cc ('K') | « extensions/common/test_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698