Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 569493003: Remove CreateEmptyExtension from extension_function_test_utils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/browser/extensions/extension_function_test_utils.h" 9 #include "chrome/browser/extensions/extension_function_test_utils.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
11 #include "chrome/browser/extensions/extension_test_message_listener.h" 11 #include "chrome/browser/extensions/extension_test_message_listener.h"
12 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/extensions/application_launch.h" 13 #include "chrome/browser/ui/extensions/application_launch.h"
14 #include "chrome/common/chrome_paths.h" 14 #include "chrome/common/chrome_paths.h"
15 #include "chrome/test/base/in_process_browser_test.h" 15 #include "chrome/test/base/in_process_browser_test.h"
16 #include "chrome/test/base/ui_test_utils.h" 16 #include "chrome/test/base/ui_test_utils.h"
17 #include "extensions/browser/api/dns/host_resolver_wrapper.h" 17 #include "extensions/browser/api/dns/host_resolver_wrapper.h"
18 #include "extensions/browser/api/dns/mock_host_resolver_creator.h" 18 #include "extensions/browser/api/dns/mock_host_resolver_creator.h"
19 #include "extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h" 19 #include "extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h"
20 #include "extensions/common/test_util.h"
20 #include "extensions/test/result_catcher.h" 21 #include "extensions/test/result_catcher.h"
21 #include "net/dns/mock_host_resolver.h" 22 #include "net/dns/mock_host_resolver.h"
22 #include "net/test/spawned_test_server/spawned_test_server.h" 23 #include "net/test/spawned_test_server/spawned_test_server.h"
23 24
24 using extensions::Extension; 25 using extensions::Extension;
25 using extensions::core_api::SocketsTcpServerCreateFunction; 26 using extensions::core_api::SocketsTcpServerCreateFunction;
26 27
27 namespace utils = extension_function_test_utils; 28 namespace utils = extension_function_test_utils;
28 29
29 namespace { 30 namespace {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // it's created, which is actually a stronger rule than its real counterpart. 64 // it's created, which is actually a stronger rule than its real counterpart.
64 // But that's fine; it's good practice. 65 // But that's fine; it's good practice.
65 scoped_refptr<extensions::MockHostResolverCreator> resolver_creator_; 66 scoped_refptr<extensions::MockHostResolverCreator> resolver_creator_;
66 }; 67 };
67 68
68 } // namespace 69 } // namespace
69 70
70 IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPCreateGood) { 71 IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPCreateGood) {
71 scoped_refptr<SocketsTcpServerCreateFunction> 72 scoped_refptr<SocketsTcpServerCreateFunction>
72 socket_create_function(new SocketsTcpServerCreateFunction()); 73 socket_create_function(new SocketsTcpServerCreateFunction());
73 scoped_refptr<Extension> empty_extension(utils::CreateEmptyExtension()); 74 scoped_refptr<Extension> empty_extension(
75 extensions::test_util::CreateEmptyExtension());
74 76
75 socket_create_function->set_extension(empty_extension.get()); 77 socket_create_function->set_extension(empty_extension.get());
76 socket_create_function->set_has_callback(true); 78 socket_create_function->set_has_callback(true);
77 79
78 scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult( 80 scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(
79 socket_create_function.get(), "[]", browser(), utils::NONE)); 81 socket_create_function.get(), "[]", browser(), utils::NONE));
80 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType()); 82 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
81 base::DictionaryValue *value = 83 base::DictionaryValue *value =
82 static_cast<base::DictionaryValue*>(result.get()); 84 static_cast<base::DictionaryValue*>(result.get());
83 int socketId = -1; 85 int socketId = -1;
(...skipping 19 matching lines...) Expand all
103 extensions::ResultCatcher catcher; 105 extensions::ResultCatcher catcher;
104 const Extension* extension = LoadExtension(path); 106 const Extension* extension = LoadExtension(path);
105 ASSERT_TRUE(extension); 107 ASSERT_TRUE(extension);
106 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 108 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
107 109
108 UnloadExtension(extension->id()); 110 UnloadExtension(extension->id());
109 111
110 ASSERT_TRUE(LoadExtension(path)) << message_; 112 ASSERT_TRUE(LoadExtension(path)) << message_;
111 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 113 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
112 } 114 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698