Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 568413003: Fix typedef for InternetDetailedInfo in internet_detail.js (Closed)

Created:
6 years, 3 months ago by stevenjb
Modified:
6 years, 3 months ago
Reviewers:
Vitaly Pavlenko
CC:
chromium-reviews, dbeam+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix typedef for InternetDetailedInfo in internet_detail.js Updates https://codereview.chromium.org/543493002 for latest version if internet_detail.js BUG=393873 R=vitalyp@chromium.org Committed: https://crrev.com/b5ddaba963c4424a8f4a04f05d06fdc0a3f85890 Cr-Commit-Position: refs/heads/master@{#294900}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix typdef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -18 lines) Patch
M chrome/browser/resources/options/chromeos/internet_detail.js View 1 11 chunks +54 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
stevenjb
6 years, 3 months ago (2014-09-15 17:28:31 UTC) #2
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/568413003/diff/1/chrome/browser/resources/options/chromeos/internet_detail.js File chrome/browser/resources/options/chromeos/internet_detail.js (right): https://chromiumcodereview.appspot.com/568413003/diff/1/chrome/browser/resources/options/chromeos/internet_detail.js#newcode18 chrome/browser/resources/options/chromeos/internet_detail.js:18: * carriers: boolean, As it's being put in a ...
6 years, 3 months ago (2014-09-15 19:18:08 UTC) #3
stevenjb
ptal https://chromiumcodereview.appspot.com/568413003/diff/1/chrome/browser/resources/options/chromeos/internet_detail.js File chrome/browser/resources/options/chromeos/internet_detail.js (right): https://chromiumcodereview.appspot.com/568413003/diff/1/chrome/browser/resources/options/chromeos/internet_detail.js#newcode18 chrome/browser/resources/options/chromeos/internet_detail.js:18: * carriers: boolean, On 2014/09/15 19:18:08, Vitaly Pavlenko ...
6 years, 3 months ago (2014-09-15 19:52:35 UTC) #4
Vitaly Pavlenko
lgtm
6 years, 3 months ago (2014-09-15 20:29:17 UTC) #5
stevenjb
Committed patchset #2 (id:20001) to pending queue manually as 09b22bf (presubmit successful).
6 years, 3 months ago (2014-09-15 22:15:55 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 22:29:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5ddaba963c4424a8f4a04f05d06fdc0a3f85890
Cr-Commit-Position: refs/heads/master@{#294900}

Powered by Google App Engine
This is Rietveld 408576698